Merge lp:~gary/juju-gui/hidehelp into lp:juju-gui/experimental

[Gary Poster]

Tweak help text to not obscure charm browser

https://codereview.appspot.com/9036047/

[Gary Poster (gary)]

Reviewers: mp+161675_code.launchpad.net,

Message:
Please take a look.

Description:
Tweak help text to not obscure charm browser

Trivial.

https://code.launchpad.net/~gary/juju-gui/hidehelp/+merge/161675

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/9036047/

Affected files:
   A [revision details]
   M lib/views/browser/main.less
   M lib/views/stylesheet.less

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/views/stylesheet.less
=== modified file 'lib/views/stylesheet.less'
--- lib/views/stylesheet.less 2013-04-28 20:03:01 +0000
+++ lib/views/stylesheet.less 2013-04-30 18:37:33 +0000
@@ -281,6 +281,10 @@
  #environment-help {
    color: #757575;
    text-align: center;
+ /* This is absolute so that it does not push the svg down when it is
+ visible. That's important for animations hiding and showing this
help,
+ and if we want the help to appear when a service is present (such as
the
+ GUI itself). */
    position: absolute;
    overflow: hidden;
    padding: 0;
@@ -291,7 +295,7 @@
    pointer-events: none;
    div.vertical-center-floater {
      height: 50%;
- margin-bottom: -225px;
+ margin-bottom: -250px;
      margin-top: 0;
      min-height: 225px;
    }

Index: lib/views/browser/main.less
=== modified file 'lib/views/browser/main.less'
--- lib/views/browser/main.less 2013-04-29 18:38:00 +0000
+++ lib/views/browser/main.less 2013-04-30 18:37:33 +0000
@@ -249,6 +249,7 @@
    #bws-fullscreen {
      bottom: @canvas-footer-nav-height;
      background-color: #f5f5f5;
+ z-index: 1;
    }
    .bws-view-data,
    #bws-sidebar .bws-content {
@@ -279,7 +280,6 @@
      }
    }
    #bws-sidebar {
- z-index: 1;
      right: auto;
      width: @bws-sidebar-width;
      overflow: hidden;

[Gary Poster (gary)]

*** Submitted:

Tweak help text to not obscure charm browser

R=
CC=
https://codereview.appspot.com/9036047

https://codereview.appspot.com/9036047/

=== modified file 'lib/views/browser/main.less'
--- lib/views/browser/main.less	2013-04-29 18:38:00 +0000
+++ lib/views/browser/main.less	2013-04-30 18:49:27 +0000
@@ -249,6 +249,7 @@
   #bws-fullscreen {
     bottom: @canvas-footer-nav-height;
     background-color: #f5f5f5;
+    z-index: 1;
   }
   .bws-view-data,
   #bws-sidebar .bws-content {
@@ -279,7 +280,6 @@
     }
   }
   #bws-sidebar {
-    z-index: 1;
     right: auto;
     width: @bws-sidebar-width;
     overflow: hidden;

=== modified file 'lib/views/stylesheet.less'
--- lib/views/stylesheet.less	2013-04-28 20:03:01 +0000
+++ lib/views/stylesheet.less	2013-04-30 18:49:27 +0000
@@ -281,6 +281,10 @@
 #environment-help {
   color: #757575;
   text-align: center;
+  /* This is absolute so that it does not push the svg down when it is
+     visible.  That's important for animations hiding and showing this help,
+     and if we want the help to appear when a service is present (such as the
+     GUI itself). */
   position: absolute;
   overflow: hidden;
   padding: 0;
@@ -291,7 +295,7 @@
   pointer-events: none;
   div.vertical-center-floater {
     height: 50%;
-    margin-bottom: -225px;
+    margin-bottom: -250px;
     margin-top: 0;
     min-height: 225px;
   }