lp:~gary/juju-gui/hidehelp
- Get this branch:
- bzr branch lp:~gary/juju-gui/hidehelp
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 43 lines (+6/-2)2 files modifiedlib/views/browser/main.less (+1/-1)
lib/views/stylesheet.less (+5/-1)
Related source package recipes
Branch information
Recent revisions
- 629. By Richard Harding
-
Show spinny indicator in browser when loading
- add indicator support to sidebar/fullscreen landing pages
- add indicator support to the search loading
- add indicator support to loading a charm details viewR=matthew.scott, gary.poster
CC=
https://codereview. appspot. com/9052043 - 628. By Jeff Pihach
-
Created a model controller with promises
This branch takes the work from a number of previous branches
and combined the work under a single ModelController class which
will be used from now on to interact with the models and db
to avoid having to pass the env and db into them.This also implements a sandbox fix from Gary.
Individual unit tests will be coming in a follow-up but in the
mean time all of this code is tested indirectly by the endpoints
tests.R=gary.poster, rharding
CC=
https://codereview. appspot. com/8686047 - 627. By Benji York
-
Add a Makefile npm-cache target to upload to LP
There is a parallel charm branch that uses the cache file to speed deploying
of branch builds.R=rharding, gary.poster
CC=
https://codereview. appspot. com/8686048 - 625. By Richard Harding
-
Adds filter controls to the search in the browser
- The branch updates the models/browser.js Filter model that is basically the
search state in the application.
- The subapp keeps an instance of that around and updates it along with the
rest of the subapplication state.
- The subapp passes the raw data down into views that can use it to populate
the search related widgets (search and filters).
- When those widgets are changed they trigger a custom event back up to their
controlling View.
- That View then generates a change event to the subapp directing it to update
it's current _filter (the Filter model) with that change and navigate to the
new url.
- All searches are url-able and thus force a navigate and re-process through
the render chain.
- Because of this, the Views do not need to update their version of the
filters, they'll get new ones from the subapp on the next routing.Known QA issues:
- There's not a good "no results found" display
- There's not a list of selected filters per UX design when the filter list is
collapsed in sidebar view
- Theme'ing needs to be done on the filter list to remove the leading *, make
things more header-like, add proper arrows vs temp ^/v
- It's felt these are correctable through the week while the functionality is
able to be added before 'feature freeze' on Monday.R=j.c.sackett, benji
CC=
https://codereview. appspot. com/9003043 - 623. By Richard Harding
-
Add failing provider notice and fix #1173333
- When a provider is known to be failing add a warning container and show the
provider icon.
- Drive by fix for #1173333 to make sure that we can 'deactive' a selected
charm in the editorial and search views.R=gary.poster, j.c.sackett
CC=
https://codereview. appspot. com/8651046 - 622. By Richard Harding
-
Add the 'is reviwed' badge to the charm icons
- Add the original svg given in case we need it at different sizes
- Save a .png version for use in sprites
- Add the check/html to the templates
- Add the css in both locations, charm-token and the full charm details
display.R=j.c.sackett, matthew.scott
CC=
https://codereview. appspot. com/8797047 - 621. By Gary Poster
-
Help on empty canvas
The env view should show some help text when the canvas is empty.
Landing work from bcsaller that I modified.
R=rharding
CC=
https://codereview. appspot. com/8961049
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental
