Merge lp:~gary/charms/precise/juju-gui/fix-charm-proof into lp:~juju-gui/charms/precise/juju-gui/trunk

[Gary Poster]

Fix charm according to "charm proof"

Add copyright file and maintainer, and remove "juju" key.

https://codereview.appspot.com/7131063/

[Gary Poster (gary)]

Reviewers: mp+143963_code.launchpad.net,

Message:
Please take a look.

Description:
Fix charm according to "charm proof"

Add copyright file and maintainer, and remove "juju" key.

https://code.launchpad.net/~gary/charms/precise/juju-gui/fix-charm-proof/+merge/143963

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7131063/

Affected files:
   A [revision details]
   A copyright
   M metadata.yaml

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision: <email address hidden>

Index: copyright
=== added file 'copyright'
--- copyright 1970-01-01 00:00:00 +0000
+++ copyright 2013-01-18 22:47:52 +0000
@@ -0,0 +1,17 @@
+Format: http://dep.debian.net/deps/dep5/
+
+Files: *
+Copyright: Copyright 2011, Canonical Ltd., All Rights Reserved.
+License: GPL-3
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
\ No newline at end of file

Index: metadata.yaml
=== modified file 'metadata.yaml'
--- metadata.yaml 2012-11-19 12:15:36 +0000
+++ metadata.yaml 2013-01-18 22:47:52 +0000
@@ -1,7 +1,7 @@
-juju: charm
  name: juju-gui
  summary: User interface for Juju (development)
  description: Web GUI for Juju
  provides:
    web:
      interface: http
+maintainer: Juju GUI Team <email address hidden>
\ No newline at end of file

[Francesco Banconi (frankban)]

Thanks Gary, this branch fixes all the errors and warnings found by
`charm proof`. The only remaining output is:
I: relation web has no hooks
... but that's just an info message.
To double check, I run the tests and deployed the charm: everything
works well.
So, land with just the minor below.
I can take care of landing this branch after the second review is done.

https://codereview.appspot.com/7131063/diff/1/copyright
File copyright (right):

https://codereview.appspot.com/7131063/diff/1/copyright#newcode4
copyright:4: Copyright: Copyright 2011, Canonical Ltd., All Rights
Reserved.
Maybe 2013?

https://codereview.appspot.com/7131063/

[Brad Crittenden (bac)]

Looks good to land after the copyright change.

https://codereview.appspot.com/7131063/

[lp:~gary/charms/precise/juju-gui/fix-charm-proof]

27. By Francesco Banconi on 2013-01-21

Fix charm according to "charm proof"

Add copyright file and maintainer, and remove "juju" key.
Landing Gary's branch.

R=
CC=
https://codereview.appspot.com/7182044

=== added file 'copyright'
--- copyright	1970-01-01 00:00:00 +0000
+++ copyright	2013-01-18 22:50:29 +0000
@@ -0,0 +1,17 @@
+Format: http://dep.debian.net/deps/dep5/
+
+Files: *
+Copyright: Copyright 2011, Canonical Ltd., All Rights Reserved.
+License: GPL-3
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
\ No newline at end of file

=== modified file 'metadata.yaml'
--- metadata.yaml	2012-11-19 12:15:36 +0000
+++ metadata.yaml	2013-01-18 22:50:29 +0000
@@ -1,7 +1,7 @@
-juju: charm
 name: juju-gui
 summary: User interface for Juju (development)
 description: Web GUI for Juju
 provides:
   web:
     interface: http
+maintainer: Juju GUI Team <[e-mail]>
\ No newline at end of file