Merge lp:~gary-wzl77/ubuntu-weather-app/fix_1518888 into lp:ubuntu-weather-app

[Gary.Wang]

1.Add url-dispatcher to enable user to navigate weather app from weather scope
2.Add argument(display) to show hourly view when its value is "hourly" on startup

1.Add url-dispatcher to enable user to navigate weather app from weather scope.
2.Add argument(display) to show hourly view when its value is "hourly" on startup.

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

PASSED: Continuous integration, rev:194
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/32/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/304/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/32/rebuild

review: Approve (continuous-integration)

[lp:~gary-wzl77/ubuntu-weather-app/fix_1518888]

194. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-06

Launchpad automatic translations update.

[Andrew Hayzen (ahayzen)]

Thanks for starting this :-)

I've found a few issues while looking at the code:
1) You are using Arguments not Connections { target: UriHandler; onOpened: { ... } } which means that the UrlHandler only works when the app is first started, not if the application was already running. Please refer to the docs [0] or music app [1] for how this works.
2) The idea is that this will be run from the scope, however you can search for any location in the scope and you can have any set of locations loaded in the weather app. So I could be on London in the scope, then click to open the weather-app and the weather-app could be at Berlin, this would not be very useful.

I suggest that you provide the latitude and longitude into the UriHandler so use something such as weather://latitiude/longitude/days for example for London hourly this could be weather://51.50853/0.12574/1 or for a 5 day forecast you could then use weather://51.50853/0.12574/5

The weather could the detect if the location exists and switch to the relevant page, or if it doesn't show a temporary view that allows them to view the info, but also save that as a location in their list.

It's probably best that a mail thread is started between the weather app devs, if we want to discuss the protocol design further.

Furthermore could you add yourself to the AUTHORS file and add an entry into the debian/changelog (use the tool $ dch ).

0 - https://developer.ubuntu.com/api/apps/qml/sdk-15.04.1/Ubuntu.Components.UriHandler/
1 - http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/view/head:/app/components/Helpers/UriHandlerHelper.qml#L29

review: Needs Fixing

[Gary.Wang (gary-wzl77)]

Thanks for your reply.

1) You are using Arguments not Connections { target: UriHandler; onOpened:
{ ... } } which means that the UrlHandler only works when the app is first
started, not if the application was already running. Please refer to the
docs [0] or music app [1] for how this works.
A: Good suggestion, will fix in next MR update.

2) The idea is that this will be run from the scope, however you can search
for any location in the scope and you can have any set of locations loaded
in the weather app. So I could be on London in the scope, then click to
open the weather-app and the weather-app could be at Berlin, this would not
be very useful.
A: That's also an idea from David who reviews weather scope. will fix in
weather scope at first.

I suggest that you provide the latitude and longitude into the UriHandler
so use something such as weather://latitude/longitude/days for example for
London hourly this could be weather://51.50853/0.12574/1 or for a 5 day
forecast you could then use weather://51.50853/0.12574/5
A: weather://51.50853/0.12574/5 format is not that reasonable. I prefer
to keep current implementation(url parameters) by appending geo
information. E.g.
weather://?display=hourly&city=London&lat=51.50853&lng=-0.12574
weather://?display=default&city=London&lat=51.50853&lng=-0.12574

The weather could the detect if the location exists and switch to the
relevant page, or if it doesn't show a temporary view that allows them to
view the info, but also save that as a location in their list.
A: That's my general idea for this as well. if location exists, switch to
the relevant page. if not, searching location info based on lat&lng at
firstly, and switch to the regarding page then.

Thanks. Will update the MR later on.

On Wed, Jan 6, 2016 at 8:40 PM, Andrew Hayzen <email address hidden> wrote:

> Review: Needs Fixing
>
> Thanks for starting this :-)
>
> I've found a few issues while looking at the code:
> 1) You are using Arguments not Connections { target: UriHandler; onOpened:
> { ... } } which means that the UrlHandler only works when the app is first
> started, not if the application was already running. Please refer to the
> docs [0] or music app [1] for how this works.
> 2) The idea is that this will be run from the scope, however you can
> search for any location in the scope and you can have any set of locations
> loaded in the weather app. So I could be on London in the scope, then click
> to open the weather-app and the weather-app could be at Berlin, this would
> not be very useful.
>
> I suggest that you provide the latitude and longitude into the UriHandler
> so use something such as weather://latitiude/longitude/days for example for
> London hourly this could be weather://51.50853/0.12574/1 or for a 5 day
> forecast you could then use weather://51.50853/0.12574/5
>
> The weather could the detect if the location exists and switch to the
> relevant page, or if it doesn't show a temporary view that allows them to
> view the info, but also save that as a location in their list.
>
> It's probably best that a mail thread is started between the weather app
> devs, if we want to discuss the protocol design further.
>
>
> Furtherm...

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

FAILED: Continuous integration, rev:195
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/73/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/339/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/73/rebuild

review: Needs Fixing (continuous-integration)

[Gary.Wang (gary-wzl77)]

Hi Andrew
1. Does the missing API key cause test run failed?
2. Is there any access limits for following API, at times I didn't get respond from it for a long time
http://api.geonames.org/findNearbyPlaceNameJSON?style=full&username=uweatherdev&lat=51.5047&lng=-0.1283&maxRows=25&featureClass=P

Thanks.

[lp:~gary-wzl77/ubuntu-weather-app/fix_1518888]

195. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-09

Launchpad automatic translations update.

[Andrew Hayzen (ahayzen)]

1) Yup, you will require the API keys to OWM/TWC to run the tests, please message me privately if you require them
2) geonames does have a limit and there is a bug 1326918 to migrate to the ubuntu one.

[lp:~gary-wzl77/ubuntu-weather-app/fix_1518888]

196. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-13

Launchpad automatic translations update.

197. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-14

Launchpad automatic translations update.

198. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-28

Launchpad automatic translations update.

199. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-29

Launchpad automatic translations update.

200. By Andrew Hayzen on 2016-01-29

* Use sidestage so that tablets don't go into portrait mode.

Approved by Jenkins Bot, Alan Pope .

201. By Victor Thompson on 2016-01-29

* Change translatable string from "rain" to "precipitation". Fixes: https://bugs.launchpad.net/bugs/1521701.

Approved by Jenkins Bot, Bartosz Kosiorek.

202. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-30

Launchpad automatic translations update.

203. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-01-31

Launchpad automatic translations update.

204. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-01

Launchpad automatic translations update.

205. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-02

Launchpad automatic translations update.

206. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-03

Launchpad automatic translations update.

207. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-04

Launchpad automatic translations update.

208. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-05

Launchpad automatic translations update.

209. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-06

Launchpad automatic translations update.

210. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-07

Launchpad automatic translations update.

211. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-08

Launchpad automatic translations update.

212. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-09

Launchpad automatic translations update.

213. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-10

Launchpad automatic translations update.

214. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-11

Launchpad automatic translations update.

215. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-13

Launchpad automatic translations update.

216. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-16

Launchpad automatic translations update.

217. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-17

Launchpad automatic translations update.

218. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-23

Launchpad automatic translations update.

219. By Launchpad Translations on behalf of ubuntu-weather-dev on 2016-02-26

Launchpad automatic translations update.

220. By Gary.Wang on 2016-02-29

Add url-dispatcher to support for app launching from weather scope

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

FAILED: Continuous integration, rev:220
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1085/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/642/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1085/rebuild

review: Needs Fixing (continuous-integration)

[Andrew Hayzen (ahayzen)]

This looks to be progressing well, is there a silo or debs for the scope so that we can test this? Or are you manually running a the URI-handler from a command? If so do you mind sharing to assist in the testing of the branch?

review: Needs Information

[lp:~gary-wzl77/ubuntu-weather-app/fix_1518888]

221. By Gary.Wang on 2016-08-25

merge from trunk.

[Gary.Wang (gary-wzl77)]

Hi Andrew
   Sorry for the late response,
   I've been cleaning up the bugs on my hand, The following link you can find a armhf-based test scope, which allows you to open weather app from the scope and check the current temperature for three different locations.
   London(belvedere)
   Berlin(mitte)
   Roma(trevi)

   https://drive.google.com/open?id=0B2H9ECPSSfqIc2xybjlxc0F4SGc
   Please playing around it and verify it on the device.

   Thanks.
   Sorry again for the delay.

P.S due to the API count limitation, sometimes main view didn't navigate to specific location page as we didn't get current temperature information.

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

PASSED: Continuous integration, rev:221
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/73/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/971/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/weather-app-ci/73/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

I've installed the scope and this branch on my device.

I've noticed a few functional issues to discuss first:
1) When I open via the scope, it causes all of the views (swiping across) to change to have the hourly view already shown, is this a design decision or an issue? (I wasn't expecting *all* the locations to change to hourly view, maybe only the location I had clicked in the scope)
2) I know you said there were API limitations, but I have not yet been able to select one of the locations in the scopes and then receive the respective location in the app. It always jumps to my 2nd non-location detected location.

Could you describe the expected scenarios here? For example
- if you click on a location and you already have the location, I assume it would jump to it?
- if you click on a location and you don't already have the location, I assume it will add a section - but will this be temporary? or remain in the saved list?

Also are you expecting this to work with both OpenWeatherMap and TheWeatherChannel.

If you want to discuss any of these issues with me, feel free to ping me (ahayzen) on IRC. I'm around in London daytime.

review: Needs Fixing

[lp:~gary-wzl77/ubuntu-weather-app/fix_1518888]

222. By Gary.Wang on 2016-10-08

refresh data even if location exists, which allows to show respective location's weather info if it can be found in db.

[Gary.Wang (gary-wzl77)]

Sorry for the late reply(Just got back from vacation).

Basically, regarding the issue you have that
" It always jumps to my 2nd non-location detected location."
I guess you got the problem by checking the location from scope that app has recorded in db.
Indeed, i can reproduce it and fixed it in the latest commit.

Could you describe the expected scenarios here? For example
- if you click on a location and you already have the location, I assume it would jump to it?
A: Yes
- if you click on a location and you don't already have the location, I assume it will add a section - but will this be temporary? or remain in the saved list?
A:It will add a new location and save it in the location list and navigate to hourlyView to show the location's weather info.

I record a video to show how it works under the scenarios you mentioned above.
https://drive.google.com/open?id=0B2H9ECPSSfqIak42YmU4MGducGs

Pre-condition:
    App only records my current location(Chengdu)

1. Click 'London' in scope to add a new location(Belvedere) in weather app(scenario 2)
2. Click 'Berlin' in scope to add a new location(Mitte) in weather app(scenario 2)
3. Click 'London' again from scope to jump to respective location(Belvedere) in weather app (scenario 1)
4. Click 'Roma' from scope to add a new location(Trevi) in weather app (scenario 2)

P.S:
1.if weather information is not able to be fetched via lat&lng due to api limits, the expected result is "Just open the app and stays at hourly view"
2.During my testing, new feature works fine with two providers(open weather map/the weather channel). In general, as long as backend APIs support to retrieve weather info via latitude and longitude, there would be no problem to add new provider in the future.

[Andrew Hayzen (ahayzen)]

As discussed, it seems my issues occur when a manual location (London) has been added via the search functionality in the app.

Otherwise, when I don't have and manual search locations added, this functions as expected :-)

[Gary.Wang (gary-wzl77)]

OKay, after taking a closer look, basically it's a bug of the scope, not weather app. I hardcoded the location name("London") for each item in scope. That's why it always jumps to the detected location(London) during your testing.

After the following change was made in scope, it should be working well.
- std::string openUri = "weather://?display=hourly&city=London&lat=" + lat + "&lng=" + lng;
+std::string openUri = "weather://?display=hourly&city=" + loc + "&lat=" + lat + "&lng=" + lng;

I attached the latest scope. Could you please have a check again?
https://drive.google.com/open?id=0B2H9ECPSSfqIZkY4UzhnWGJydzA

Sorry for the noise.
Thanks. :)

[Andrew Hayzen (ahayzen)]

OK this is looking better, the only thing i've noticed is that if I have London as a location, when I click London it still jumps to London rather than Belvedere. But I'm thinking that is expected as it is coming from the &city=" + loc + " part of the uri.

So functionally I think this is pretty much there, I'll work on doing a code review next :-)

[Andrew Hayzen (ahayzen)]

So testing this I’ve found that the restoration of which index you had previously selected is broken (but it also appears to be in trunk as well?)

Also in the code you have stated "NOTE: potential minor issue: cities with the same name in different countries", I think the best thing todo is report a bug with low priority stating the scenario in which this could happen.

Therefore I'm going to approve this branch, and we can fix the other issues separately.

review: Approve

=== modified file 'AUTHORS'
--- AUTHORS	2016-01-18 22:47:05 +0000
+++ AUTHORS	2016-10-08 08:45:35 +0000
@@ -9,3 +9,5 @@
 Nekhelesh Ramananthan <[e-mail]>
 Vamshi Balanaga <[e-mail]>
 Victor Thompson <[e-mail]>
+Carla Sella <[e-mail]>
+Gary Wang <[e-mail]>

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-11-01 18:35:08 +0000
+++ CMakeLists.txt	2016-10-08 08:45:35 +0000
@@ -32,6 +32,7 @@
 set(APP_HARDCODE ubuntu-weather-app)
 set(MAIN_QML app/${APP_HARDCODE}.qml)
 set(DESKTOP_FILE "${APP_HARDCODE}.desktop")
+set(URLS_FILE "${APP_HARDCODE}.url-dispatcher")
 set(ICON app/[e-mail])
 set(AUTOPILOT_DIR ubuntu_weather_app)
 
@@ -41,8 +42,9 @@
   set(UBUNTU-WEATHER_APP_DIR "${CMAKE_INSTALL_DATADIR}/qml")
 
   set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}")
-  set(EXEC "qmlscene $@ ${MAIN_QML}")
+  set(EXEC "qmlscene %u ${MAIN_QML}")
   set(DATA_DIR /)
+  set(URLS_DIR ${DATA_DIR})
 
   set(MODULE_PATH ${QT_IMPORTS_DIR})
   if(NOT BZR_REVNO)
@@ -97,6 +99,8 @@
 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
         DESTINATION ${CMAKE_INSTALL_DATADIR}/applications)
 
+install(FILES ${URLS_FILE} DESTINATION ${URLS_DIR})
+
 add_subdirectory(app)
 add_subdirectory(po)
 add_subdirectory(tests)

=== modified file 'app/components/CurrentLocation.qml'
--- app/components/CurrentLocation.qml	2016-07-19 11:24:58 +0000
+++ app/components/CurrentLocation.qml	2016-10-08 08:45:35 +0000
@@ -28,26 +28,6 @@
 
     property string string: "Undefined"
 
-    function searchForLocation(lat, lon) {
-        WeatherApi.sendRequest({
-                                   action: "searchByPoint",
-                                   params: {
-                                       coords: {
-                                           lat: lat,
-                                           lon: lon
-                                       }
-                                   }
-                               }, searchResponseHandler)
-    }
-
-    function searchResponseHandler(msgObject) {
-        if (!msgObject.error && settings.detectCurrentLocation) {
-            console.log("Loc to add:", JSON.stringify(msgObject.result.locations[0]))
-            storage.updateCurrentLocation(msgObject.result.locations[0])
-        }
-    }
-
-
     PositionSource {
         id: currentPosition
         updateInterval: 1000
@@ -80,7 +60,10 @@
 
         onCountChanged: {
             // Update the currentLocation if one is found and it does not match the stored location
-            if (count > 0 && currentLocation.string !== geocodeModel.get(0).address.city) {
+            // if there is a location request from url on startup, we ignore this first a few times when signal is triggerd
+            // to avoid view position to current location. It works after requestLocationByUrl was set to undefined
+            if (weatherApp.requestLocationByUrl === undefined
+                    && count > 0 && currentLocation.string !== geocodeModel.get(0).address.city) {
                 search();
             }
         }
@@ -88,7 +71,7 @@
         function search() {
             var loc = geocodeModel.get(0)
             currentLocation.string = loc.address.city
-            searchForLocation(loc.coordinate.latitude, loc.coordinate.longitude)
+            searchForLocation("searchByPoint", loc.coordinate.latitude, loc.coordinate.longitude)
         }
     }
 

=== modified file 'app/components/HomeHourly.qml'
--- app/components/HomeHourly.qml	2015-11-02 21:28:34 +0000
+++ app/components/HomeHourly.qml	2016-10-08 08:45:35 +0000
@@ -39,7 +39,7 @@
     MouseArea {
         anchors.fill: parent
         onClicked: {
-            homeGraphic.visible = true
+            graphicVisible = true
         }
     }
 

=== modified file 'app/data/WeatherApi.js'
--- app/data/WeatherApi.js	2016-06-04 21:02:30 +0000
+++ app/data/WeatherApi.js	2016-10-08 08:45:35 +0000
@@ -797,7 +797,8 @@
     // perform the api calls
     if(message.action === "searchByName") {
         WeatherApi.search("name", message.params, finished, onError);
-    } else if(message.action === "searchByPoint") {
+    } else if(message.action === "searchByPoint"
+              || message.action === "searchByUrl") {
         WeatherApi.search("point", message.params, finished, onError);
     } else if(message.action === "getGeoIp") {
         WeatherApi.geoLookup(message.params, finished, onError);

=== modified file 'app/data/keys.js'
--- app/data/keys.js	2015-11-09 10:37:47 +0000
+++ app/data/keys.js	2016-10-08 08:45:35 +0000
@@ -1,2 +1,2 @@
 var twcKey = "";
-var owmKey = "";  // See README for details on how to obtain a personal API key
+var owmKey = ""; // goto http://openweathermap.org/appid to get a personal API key

=== modified file 'app/ubuntu-weather-app.qml'
--- app/ubuntu-weather-app.qml	2015-11-02 21:28:34 +0000
+++ app/ubuntu-weather-app.qml	2016-10-08 08:45:35 +0000
@@ -64,11 +64,27 @@
     property bool networkError: false
 
     /*
+      Indicates of the location info requested from Url
+    */
+    property var requestLocationByUrl;
+
+    /*
       (re)load the pages on completion
     */
     Component.onCompleted: {
+        var url = args.defaultArgument.at(0)
+        var argus = parseArguments(url);
+
+        mainPageStack.push(Qt.resolvedUrl("ui/HomePage.qml"), {"hourlyVisible": argus.hourlyVisible})
+
         storage.getLocations(fillPages);
-        refreshData();
+        if (argus.city && argus.lat && argus.lng) {
+            if (positionViewAtCity(argus.city) === -1) {
+                searchForLocation("searchByUrl", argus.lat, argus.lng)
+            }
+        } else {
+            refreshData();
+        }
     }
 
     /*
@@ -86,6 +102,20 @@
                  });
                  //print(JSON.stringify(messageObject.result));
                  fillPages(messageObject.result);
+
+                 //1.Re-position current display index at requested location index
+                 //2.Prevent index changed after reorder when geoChanged is triggered on startup
+                 if (requestLocationByUrl) {
+                     for (var i = 0; i < locationsList.length; i++) {
+                         var loc = locationsList[i].location;
+                         if (requestLocationByUrl !== undefined && loc.services.geonames !== undefined &&
+                                 requestLocationByUrl.services.geonames === loc.services.geonames) {
+                             settings.current = i;
+                             requestLocationByUrl = undefined
+                             break;
+                         }
+                     }
+                 }
              }
          } else {
              console.log(messageObject.error.msg+" / "+messageObject.error.request.url)
@@ -113,7 +143,7 @@
         } else {
             storage.getLocations(function(locations) {
                 WeatherApi.sendRequest({
-                    action: "updateData",
+                    action:  "updateData",
                     params: {
                         locations: locations,
                         force: force_refresh,
@@ -127,6 +157,143 @@
         }
     }
 
+    /*
+      parse arguments retrieved from url. The url format can be as following:
+      weather://?display=hourly&city=London&lat=51.50853&lng=-0.12574
+    */
+    function parseArguments(url) {
+        var arguments = url.substring(url.lastIndexOf('?') + 1).split('&');
+
+        var hourlyVisible = false;
+        var city, lat, lng;
+        var index = 0;
+        while(index < arguments.length) {
+            var params = arguments[index].split('=');
+            if (params[0] === "display")
+                hourlyVisible = params[1] === "hourly" ?  true: false;
+            if (params[0] === "lng")
+                lng = params[1];
+            if (params[0] === "lat")
+                lat = params[1];
+            if (params[0] === "city")
+                city = params[1];
+
+            index++;
+        }
+
+        return {"hourlyVisible": hourlyVisible, "city": city, "lat":  lat, "lng" : lng}
+    }
+
+    /*
+      Positions the view that with the specified cityName,
+      return pos index of the city if it can be found in locationlist
+      and return -1 if city is not found in locationlist.
+      NOTE: potential minor issue: cities with the same name in different countries
+    */
+    function positionViewAtCity(cityName) {
+        var index = -1;
+
+        for (var i = 0; i < locationsList.length; i++) {
+            var loc = locationsList[i].location;
+            if (cityName === loc.name) {
+                settings.current =  i;
+                index  = i;
+                break;
+            }
+        }
+
+        return index;
+    }
+
+    function searchForLocation(action, lat, lon) {
+        WeatherApi.sendRequest({
+            action: action,
+            params: {
+                coords: {
+                    lat: lat,
+                    lon: lon
+                }
+            }
+        }, searchResponseHandler)
+    }
+
+    function searchResponseHandler(msgObject) {
+        if (!msgObject.error ) {
+            console.log("Loc to add:", JSON.stringify(msgObject.result.locations[0]))
+            if (msgObject.action === "searchByUrl") {
+                requestLocationByUrl = msgObject.result.locations[0];
+                storage.addLocation(requestLocationByUrl)
+            } else if (settings.detectCurrentLocation) {
+                storage.updateCurrentLocation(msgObject.result.locations[0])
+            }
+        }
+    }
+
+    Arguments {
+        id: args;
+
+        defaultArgument.help: i18n.tr("One arguments for weather app: --display, --city, --lat, --lng They will be managed by system. See the source for a full comment about them");
+        defaultArgument.valueNames: ["URL"]
+
+        /* ARGUMENTS on startup
+          *
+          * Display hourly view when startup. This enable us to navigate weather app from weather scope
+          * Keyword: display
+          * Value: hourly or default
+          *
+          * Location information. This enable us to navigate relevant city weather view with geo information specified
+          * please pass all three basic geo parameters together when requesting specific city weather
+          * Keyword: city
+          * Value: city name
+          *
+          * Keyword: lat
+          * Value:  latitude of city
+          *
+          * Keyword: lng
+          * Value:  longitude of city
+          */
+
+        Argument {
+            name: "display"
+            required: false
+            valueNames: ["DISPLAY"]
+        }
+
+        Argument {
+            name: "city"
+            required: false
+            valueNames: ["CITY"]
+        }
+
+        Argument {
+            name: "lat"
+            required: false
+            valueNames: ["LATITUDE"]
+        }
+
+        Argument {
+            name: "lng"
+            required: false
+            valueNames: ["LONGITUDE"]
+        }
+    }
+
+    Connections {
+        target: UriHandler
+        onOpened: {
+            var argus = parseArguments(uris[0]);
+            if (argus.city && argus.lat && argus.lng) {
+                while (mainPageStack.depth > 1) {
+                    mainPageStack.pop()
+                }
+
+                if (positionViewAtCity(argus.city) === -1) {
+                    searchForLocation("searchByUrl", argus.lat, argus.lng)
+                }
+            }
+        }
+    }
+
     CurrentLocation {
         id: currentLocation
     }
@@ -204,8 +371,8 @@
                 if(location.dbId === undefined || location.dbId === 0) {
                     storage.insertLocation({location: location});
                 }
-                refreshData();
             }
+            refreshData();
 
             return !exists;
         }
@@ -294,6 +461,5 @@
 
     PageStack {
         id: mainPageStack
-        Component.onCompleted: mainPageStack.push(Qt.resolvedUrl("ui/HomePage.qml"))
     }
 }

=== modified file 'app/ui/HomePage.qml'
--- app/ui/HomePage.qml	2016-02-28 22:53:13 +0000
+++ app/ui/HomePage.qml	2016-10-08 08:45:35 +0000
@@ -33,6 +33,8 @@
     tipColor: UbuntuColors.orange
     tipLabelColor: "#FFF"
 
+    property bool hourlyVisible : false
+
     property var iconMap: {
         "sun": "weather-clear-symbolic",
         "moon": "weather-clear-night-symbolic",
@@ -109,6 +111,7 @@
         currentIndex: settings.current
         delegate: LocationPane {
             objectName: "locationPane" + index
+            graphicVisible: !hourlyVisible
         }
         highlightRangeMode: ListView.StrictlyEnforceRange
         model: weatherApp.locationsList.length

=== modified file 'app/ui/LocationPane.qml'
--- app/ui/LocationPane.qml	2016-06-04 21:12:07 +0000
+++ app/ui/LocationPane.qml	2016-10-08 08:45:35 +0000
@@ -43,6 +43,7 @@
     property string hourlyTempUnits
 
     property var todayData
+    property bool graphicVisible : false
 
     delegate: DayDelegate {
         day: model.day
@@ -75,10 +76,11 @@
         HomeGraphic {
             id: homeGraphic
             icon: mainPageWeekdayListView.icon
+            visible: graphicVisible;
             MouseArea {
                 anchors.fill: parent
                 onClicked: {
-                    homeGraphic.visible = false;
+                    graphicVisible = false;
                 }
             }
         }

=== modified file 'debian/changelog'
--- debian/changelog	2016-07-19 11:24:58 +0000
+++ debian/changelog	2016-10-08 08:45:35 +0000
@@ -4,6 +4,9 @@
   * Set useragent in geocode so that osm can uniquely identify our requests
   * Release 3.3 and bump version to 3.4
 
+  [ Gary Wang ]
+  * Add url-dispatcher to support for app launching from weather scope (LP: #1518888)
+
  -- Andrew Hayzen <[e-mail]>  Tue, 19 Jul 2016 12:22:57 +0100
 
 ubuntu-weather-app (3.3ubuntu1) xenial; urgency=medium

=== modified file 'manifest.json.in'
--- manifest.json.in	2016-07-19 11:24:58 +0000
+++ manifest.json.in	2016-10-08 08:45:35 +0000
@@ -5,7 +5,8 @@
     "hooks": {
         "weather": {
             "apparmor": "ubuntu-weather-app.apparmor",
-            "desktop": "@CMAKE_INSTALL_DATADIR@/applications/ubuntu-weather-app.desktop"
+            "desktop": "@CMAKE_INSTALL_DATADIR@/applications/ubuntu-weather-app.desktop",
+            "urls": "@URLS_FILE@"
         }
     },
     "icon": "@ICON@",

=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot	2016-03-26 16:48:16 +0000
+++ po/com.ubuntu.weather.pot	2016-10-08 08:45:35 +0000
@@ -1,6 +1,6 @@
 # SOME DESCRIPTIVE TITLE.
 # Copyright (C) YEAR Canonical Ltd.
-# This file is distributed under the same license as the ubuntu-weather-app package.
+# This file is distributed under the same license as the PACKAGE package.
 # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
 #
 #, fuzzy
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: ubuntu-weather-app\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2016-03-26 11:43-0500\n"
+"POT-Creation-Date: 2016-10-08 01:18-0700\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -104,6 +104,12 @@
 "to obtain your own Open Weather Map API key."
 msgstr ""
 
+#: ../app/ubuntu-weather-app.qml:235
+msgid ""
+"One arguments for weather app: --display, --city, --lat, --lng They will be "
+"managed by system. See the source for a full comment about them"
+msgstr ""
+
 #: ../app/ui/AddLocationPage.qml:38
 msgid "Select a city"
 msgstr ""

=== added file 'ubuntu-weather-app.url-dispatcher'
--- ubuntu-weather-app.url-dispatcher	1970-01-01 00:00:00 +0000
+++ ubuntu-weather-app.url-dispatcher	2016-10-08 08:45:35 +0000
@@ -0,0 +1,5 @@
+[
+	{
+		"protocol": "weather"
+	}
+]