Code review comment for lp:~gary-lasker/software-center/recommendations-categories-view

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Michael, thanks! Yes, I definitely have these items in my "refactor bad smells" list. I just opened the MP today in hopes of getting the feature in before FF, then refactor away!

Indeed, the two category classes you mention are much duplicated and really should just need be the same thing with the query passed in (and probably just handle the opt-in stuff in a subclass for the lobby view).

The update of the widget vs. making it anew was an optimization I had planned as well, as remaking it each time delays the appearance of the panes themselves (slightly noticeable in the details view).

Finally, for the uuid, I plan to give the recommender its own config (as we do for e.g. reviews). This will let us read it just the once and store the value in the RecommenderAgent class itself for easy access.

Thanks again for your review and your suggestions!!

« Back to merge proposal