Merge lp:~gary-lasker/software-center/recommendations-categories-view into lp:software-center
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 2867 |
Proposed branch: | lp:~gary-lasker/software-center/recommendations-categories-view |
Merge into: | lp:software-center |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/recommendations-categories-view |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+93491@code.launchpad.net |
Description of the change
This branch makes the recommendations view in the categories screens display properly. You can view the recommendations for a category using the current production server by navigating to the "Developer Tools" category.
All tests are updated and are passing.
Thanks!
To post a comment you must log in.
Thanks for this merge proposal! It looks good overall but I have some comments:
Recommendations PanelCategory( ) duplicated quite a bit of code from Recommendations PanelLobby, recommended_ for_you_ in_cat_ content looks almost identical to _update_ recommended_ for_you_ content _for_you_ in_cat_ agent_refresh/ _on_recommended _for_you_ agent_refresh
- _update_
- same for _on_recommended
I think we should simply make a single Recommendations PanelCategory where category can be None and a option
to show the opt-in button or not (unless I overlook something but it seems they are pretty identical).