Merge lp:~gary-lasker/software-center/add-to-launcher-after-auth-lp972710 into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 2985 |
Proposed branch: | lp:~gary-lasker/software-center/add-to-launcher-after-auth-lp972710 |
Merge into: | lp:software-center |
Diff against target: |
160 lines (+57/-25) 2 files modified
softwarecenter/backend/unitylauncher.py (+18/-2) softwarecenter/ui/gtk3/panes/availablepane.py (+39/-23) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/add-to-launcher-after-auth-lp972710 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+102605@code.launchpad.net |
Description of the change
This branch fixes bug 972710 where cancelling out of the authorization dialog for an application install leaves a (broken) icon in the Unity launcher. To fix this we now maintain a simple queue of pending installs, and we do not fire the add-to-launcher dbus signal to Unity until we get the very first transactions-
To test:
1. Choose any application and click to install (either from the list view or the details view)
2. When the auth window appears, simply cancel it.
3. Verify that the corresponding application icon is NOT found in the Unity launcher.
4. Click the install button again, but this time complete the authorizations step.
5. Verify that, within a few seconds, the icon animation occurs and the application icon is added to the Unity launcher (and shows the installation progress there).
Please also test with multiple simultaneous installs. Each will add the icon as soon as the corresponding transaction begins. The queue is maintained and cleared as each transaction completes (either finishes or is otherwise stopped).
The Unity launcher unit tests continue to work.
Many thanks for your review!
Thanks, this looks fine and works great.
One tiny question/nitpick, I noticed that: fo(object) : fo(GObject. GObject) :
-class UnityLauncherIn
+class UnityLauncherIn
and also for TransactionDetails and UnityLauncher. It seems like we don't use properties/signals
or other gobject features so I was wondering about the change? Or am I simply overlooking something?