Ubuntu Software Center

Code review comment for lp:~gary-lasker/software-center/add-to-launcher-after-auth-lp972710

  1. add-to-launcher-after-auth-lp972710
  2. Merge into trunk
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, this looks fine and works great.

One tiny question/nitpick, I noticed that:
-class UnityLauncherInfo(object):
+class UnityLauncherInfo(GObject.GObject):

and also for TransactionDetails and UnityLauncher. It seems like we don't use properties/signals
or other gobject features so I was wondering about the change? Or am I simply overlooking something?

review: Approve

« Back to merge proposal