Code review comment for lp:~gandelman-a/ubuntu/precise/horizon/typo

Adam thanks for working on this. Yes this is a simple fix, and thanks for the patch.

When building the package I get a pydist warning concerning python-django-nose. This can be corrected by adding python-django-nose to Build-Depends.

When runing lintian -iIE horizon*changes I get:

W: horizon source: syntax-error-in-dep5-copyright paragraph 2 after the field license: On Debian-based systems the full text of the Apache version 2.0 license
N:
N: The machine-readable copyright file didn't pass Debian control file
N: syntax check.
N:
N: Refer to http://dep.debian.net/deps/dep5/ for details.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: source-copyright, Type: source
N:
W: openstack-dashboard: description-synopsis-starts-with-article
N:
N: The first line of the "Description:" should omit any initial indefinite
N: or definite article: "a", "an", or "the". A good heuristic is that it
N: should be possible to substitute the package name and synopsis into this
N: formula:
N:
N: The package name provides {a,an,the,some} synopsis.
N:
N: Refer to Debian Developer's Reference section 6.2.2 (The package
N: synopsis, or short description) for details.
N:
N: Severity: minor, Certainty: certain
N:
N: Check: description, Type: binary, udeb
N:
I: openstack-dashboard: font-in-non-font-package usr/share/openstack-dashboard/dashboard/static/dashboard/css/Anivers_Regular-webfont.ttf
N:
N: This package contains a *.ttf, *.otf, or *.pfb file, file extensions
N: used by TrueType, OpenType, or Type 1 fonts, but the package does not
N: appear to be a dedicated font package. Dedicated font package names
N: should begin with fonts-. (Type 1 fonts are also allowed in packages
N: starting with xfonts-.) If the font is already packaged, you should
N: depend on that package instead. Otherwise, normally the font should be
N: packaged separately, since fonts are usually useful outside of the
N: package that embeds them.
N:
N: Severity: wishlist, Certainty: possible
N:
N: Check: files, Type: binary, udeb
N:
W: openstack-dashboard: embedded-javascript-library usr/share/openstack-dashboard/dashboard/static/dashboard/js/jquery.min.js
N:
N: This package contains an embedded copy of JavaScript libraries that are
N: now available in their own packages (for example, JQuery, Prototype,
N: Mochikit or "Cropper"). Please depend on the appropriate package and
N: symlink the library into the appropriate location.
N:
N: Refer to Debian Policy Manual section 4.13 (Convenience copies of code)
N: for details.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: files, Type: binary, udeb
N:
I: python-django-horizon: description-synopsis-might-not-be-phrased-properly
N:
N: The synopsis (first line in the package "Description:" field, the short
N: description) ends with a full stop "." character. This is not necessary,
N: as the synopsis doesn't need to be a full sentence. It is recommended
N: that a descriptive phrase is used instead.
N:
N: Note also that the synopsis is not part of the rest of the
N: "Description:" field.
N:
N: Refer to Debian Developer's Reference section 6.2.2 (The package
N: synopsis, or short description) for details.
N:
N: Severity: minor, Certainty: possible
N:
N: Check: description, Type: binary, udeb
N:
I: python-django-horizon: extended-description-is-probably-too-short
N:
N: The extended description (the lines after the first line of the
N: "Description:" field) is only one or two lines long. The extended
N: description should provide a user with enough information to decide
N: whether they want to install this package, what it contains, and how it
N: compares to similar packages. One or two lines is normally not enough to
N: do this.
N:
N: Refer to Debian Developer's Reference section 6.2.1 (General guidelines
N: for package descriptions) and Debian Developer's Reference section 6.2.3
N: (The long description) for details.
N:
N: Severity: minor, Certainty: possible
N:
N: Check: description, Type: binary, udeb
N:
W: python-django-horizon: wrong-section-according-to-package-name python-django-horizon => python
N:
N: This package has a name suggesting that it belongs to a section other
N: than the one it is currently categorized in.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: fields, Type: binary, udeb, source

It would be nice if you corrected these lintian warning or override them.

What concerns me the most is that debian/copyright does not conform to the DEP5 spec and the embedded font and java script libs.

Have a nice day
Charlie Smotherman