Merge lp:~gandelman-a/ubuntu/precise/horizon/typo into lp:ubuntu/precise/horizon
Proposed by
Adam Gandelman
| Status: | Needs review |
|---|---|
| Proposed branch: | lp:~gandelman-a/ubuntu/precise/horizon/typo |
| Merge into: | lp:ubuntu/precise/horizon |
| Diff against target: |
26 lines (+7/-1) 2 files modified
debian/changelog (+6/-0) debian/control (+1/-1) |
| To merge this branch: | bzr merge lp:~gandelman-a/ubuntu/precise/horizon/typo |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Evan Broder (community) | Needs Information | ||
| Chuck Short | Pending | ||
|
Review via email:
|
|||
Description of the change
Fixes a small fat finger in control that makes the whole thing uninstallable.
To post a comment you must log in.
Revision history for this message
| Charlie_Smotherman (cjsmo) wrote | # |
Download full text (4.7 KiB)
Unmerged revisions
- 4. By Adam Gandelman
-
debian/control: Fix trivial typo
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Adam thanks for working on this. Yes this is a simple fix, and thanks for the patch.
When building the package I get a pydist warning concerning python-django-nose. This can be corrected by adding python-django-nose to Build-Depends.
When runing lintian -iIE horizon*changes I get:
W: horizon source: syntax-
N:
N: The machine-readable copyright file didn't pass Debian control file
N: syntax check.
N:
N: Refer to http://
N:
N: Severity: normal, Certainty: possible
N:
N: Check: source-copyright, Type: source
N:
W: openstack-
N:
N: The first line of the "Description:" should omit any initial indefinite
N: or definite article: "a", "an", or "the". A good heuristic is that it
N: should be possible to substitute the package name and synopsis into this
N: formula:
N:
N: The package name provides {a,an,the,some} synopsis.
N:
N: Refer to Debian Developer's Reference section 6.2.2 (The package
N: synopsis, or short description) for details.
N:
N: Severity: minor, Certainty: certain
N:
N: Check: description, Type: binary, udeb
N:
I: openstack-
N:
N: This package contains a *.ttf, *.otf, or *.pfb file, file extensions
N: used by TrueType, OpenType, or Type 1 fonts, but the package does not
N: appear to be a dedicated font package. Dedicated font package names
N: should begin with fonts-. (Type 1 fonts are also allowed in packages
N: starting with xfonts-.) If the font is already packaged, you should
N: depend on that package instead. Otherwise, normally the font should be
N: packaged separately, since fonts are usually useful outside of the
N: package that embeds them.
N:
N: Severity: wishlist, Certainty: possible
N:
N: Check: files, Type: binary, udeb
N:
W: openstack-
N:
N: This package contains an embedded copy of JavaScript libraries that are
N: now available in their own packages (for example, JQuery, Prototype,
N: Mochikit or "Cropper"). Please depend on the appropriate package and
N: symlink the library into the appropriate location.
N:
N: Refer to Debian Policy Manual section 4.13 (Convenience copies of code)
N: for details.
N:
N: Severity: normal, Certainty: possible
N:
N: Check: files, Type: binary, udeb
N:
I: python-
N:
N: The synopsis (first line in the package "Description:" field, the short
N: description) ends with a full stop "." character. This is not necessary,
N: as the synopsis doesn't need to be a full sentence. It is recommended
N: that a descriptive phrase is used instead.
N:
N: Note also that the synopsis is not part of the rest of the
N: "D...