Code review comment for lp:~gandelman-a/ubuntu/precise/facter/lp888671

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Dave-

The 'ruby-script-but-no-ruby-dep' warning seems to only emit when I've got a Dependency on "ruby (>= 1.8) , ruby (<< 1.9)". Pegging it directly to ruby1.8 silences it (here, anyway). Perhaps introducing the dependency on 1.8 via '--sitelibdir=/usr/lib/ruby/1.8', as opposed to '#!/usr/bin/ruby1.8', is throwing lintian off?

Other two points resolved in latest push.

Thanks for the input
Adam

« Back to merge proposal