Code review comment for lp:~gael-varoquaux/ipython/ipython-sync-frontend

On Mon, Jul 27, 2009 at 10:30 PM, Gael
Varoquaux<email address hidden> wrote:
> On Tue, Jul 28, 2009 at 02:28:27AM -0000, Fernando Perez wrote:
>> I concur with your comment in console_widget.py that the _on_key_down
>> (and possibly other similar functions) might best be implemented with a
>> dict-based callback mechanism.  But since that would be a more invasive
>> change, we can postpone that thought for now.
>
> Yes, a lot of it would most probably. There might a few tricky parts
> though, with successive logic in the choice of the callback.
>
> I don't have time to do this right now, though.

No problem, I was just thinking for future work here...

>> Only question: can you let me know if there are any open tickets that I should close when merging?
>
> I hada quick look and couldn't see any.

Perfect, thanks.

This will then go in when I merge later this week, unless somebody
spots a problem.