Code review comment for ~gabrielzchen/plainbox-provider-checkbox:IR-HD-camera

Revision history for this message
Gabriel Zhi Chen (gabrielzchen) wrote :

JerryKao> spineau, joc, re: gabrielc's MR, are we going to have a test case to check HD camera in /dev/vedio0 ?, if not, I would like the MR merged as a hints for tester
<cwayne> we can't merge it as-is due to joc's comments, if anything it should be sutton-specific, not in p-p-c
<spineau> JerryKao: if you need such test case like now, then please propose a new test for sutton only
<spineau> we'll rework p-p-c to create two tests for each camera using templates but as I said, we have to update the udev parser to extract the v4l device name too (so far they are only reported with the input DEVPATH, not /dev/videoX)
<JerryKao> cwayne, spineau ok
<JerryKao> gabrielc, ^^ what do you think? 2 options, be careful when run camera preview job, or create a new job in checkbox oem?
<gabrielc> JerryKao: I prefer create a new job in checkbox oem. It is visible for all related engineers. We are easy to get the same key point in Cameras test by checkbox.
<JerryKao> gabrielc, great! please do it :)

review: Abstain

« Back to merge proposal