Merge ~gabrielzchen/plainbox-provider-checkbox:IR-HD-camera into plainbox-provider-checkbox:master

[Gabriel Zhi Chen]

    Add a verify item on camera test case.
    For Sutton project, there are some configs which have HD and IR camera.
    Lenovo wishes HD camera as the default camera.

    There are 2 bugs to refer to :

    https://bugs.launchpad.net/sutton/+bug/1790841
    https://bugs.launchpad.net/sutton/+bug/1792327

[Jonathan Cave (jocave)]

The test modified in this MR could be used on devices for any project. It is therefore possible that the camera is not HD and there is unlikely to be an IR camera. Hence, I don't think it makes sense to modify this test in this way.

Could we add a different test and identify appropriate systems to run it on?

review: Needs Fixing

[Gabriel Zhi Chen (gabrielzchen)]

JerryKao> spineau, joc, re: gabrielc's MR, are we going to have a test case to check HD camera in /dev/vedio0 ?, if not, I would like the MR merged as a hints for tester
<cwayne> we can't merge it as-is due to joc's comments, if anything it should be sutton-specific, not in p-p-c
<spineau> JerryKao: if you need such test case like now, then please propose a new test for sutton only
<spineau> we'll rework p-p-c to create two tests for each camera using templates but as I said, we have to update the udev parser to extract the v4l device name too (so far they are only reported with the input DEVPATH, not /dev/videoX)
<JerryKao> cwayne, spineau ok
<JerryKao> gabrielc, ^^ what do you think? 2 options, be careful when run camera preview job, or create a new job in checkbox oem?
<gabrielc> JerryKao: I prefer create a new job in checkbox oem. It is visible for all related engineers. We are easy to get the same key point in Cameras test by checkbox.
<JerryKao> gabrielc, great! please do it :)

review: Abstain

Unmerged commits

b8343fc... by Gabriel Zhi Chen on 2018-09-17

Add a verify item on camera test case.
For Sutton project, there are some configs which have HD and IR camera.
Lenovo wishes HD camera as the default camera.

There are 2 bugs to refer to :

https://bugs.launchpad.net/sutton/+bug/1790841
https://bugs.launchpad.net/sutton/+bug/1792327

diff --git a/units/camera/jobs.pxu b/units/camera/jobs.pxu
index 4219462..8a547cb 100644
--- a/units/camera/jobs.pxu
+++ b/units/camera/jobs.pxu
@@ -23,7 +23,8 @@ _description:
  STEPS:
      1. Click on Test to display a video capture from the camera for ten seconds.
  VERIFICATION:
-     Did you see the video capture?
+     1. Verify the default camera should be HD camera rather than IR camera.
+     2. Did you see the video capture?
 
 plugin: user-interact-verify
 template-engine: jinja2