~gabrielcocenza/juju-lint:bug/1990885-b

Last commit made on 2022-12-01
Get this branch:
git clone -b bug/1990885-b https://git.launchpad.net/~gabrielcocenza/juju-lint
Only Gabriel Cocenza can upload to this branch. If you are Gabriel Cocenza please log in for upload directions.

Branch merges

Branch information

Name:
bug/1990885-b
Repository:
lp:~gabrielcocenza/juju-lint

Recent commits

36f4a66... by Gabriel Cocenza

add subdirectories and fixed functional tests

- fixed setup.py to accept subdirectories under the jujulint project
  folder.
- changed the working directory when running functional tests with
  the snap to not use local modules.
- updated contributing for func-smoke and func-dev to run functional
  tests during development.

18b2267... by Sudeep Bhandari

Apply snap template from bootstack-charms-spec

Reviewed-on: https://code.launchpad.net/~sudeephb/juju-lint/+git/juju-lint/+merge/432609
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Eric Chen <email address hidden>

358294d... by Sudeep Bhandari

Apply snap templates

670a2d7... by Gabriel Cocenza

check that worker-multiplier is set

- added worker-multiplier config check for keystone, neutron-api,
  glance, nova-compute, nova-cloud-controller, cinder, octavia and
  placement.

Closes-Bug: #1994977

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/432421
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Mert Kirpici <email address hidden>

30312ac... by Gabriel Cocenza

check that worker-multiplier is set

- added worker-multiplier config check for keystone, neutron-api,
  glance, nova-compute, nova-cloud-controller, cinder, octavia and
  placement.

Closes-Bug: #1994977

7622096... by Chi Wai CHAN

Added custom warning message for sysconfig charm in the default lint rules.

Reviewed-on: https://code.launchpad.net/~raychan96/juju-lint/+git/juju-lint-1/+merge/432534
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Mert Kirpici <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

a521614... by Chi Wai CHAN

Added custom warning message for sysconfig charm in the default lint rules.

1108dac... by Mert Kirpici

Close LP #1993735

Reviewed-on: https://code.launchpad.net/~mertkirpici/juju-lint/+git/juju-lint/+merge/432462
Reviewed-by: Robert Gildein <email address hidden>
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>

ff6c048... by Mert Kirpici

tests/unit: rewrite test_helper_operator_check

Works-on: 1993735
Signed-off-by: Mert Kırpıcı <email address hidden>

318ea5b... by Mert Kirpici

lint: add exception to eq for empty string

The callback function `helper_operator_eq_check` for the eq operator,
has an overloaded behavior. It first tries regex matching and if that is
not successful, it tests for regular string equality checking.

This caused some issues when testing against an empty string. A check
value of empty string used to match any kind of input, which is quite
counter-intuitive.

With this change we are adding an exception for the empty string case to
force string equality check in that case. Also adding a deprecation
notice for the overloaded regex checking behavior to inform the users
that it will be removed in the future.

Works-on: 1993735
Signed-off-by: Mert Kırpıcı <email address hidden>