Merge ~raychan96/juju-lint:bug/1986773 into juju-lint:master

[Chi Wai CHAN]

Added custom warning message for sysconfig charm in the default lint rules.

The patch added a custom warning message in the `canonical-rules.yaml` and `openstack.yaml` default lint rule files when the sysconfig charm is configured with "isolcpus". The "isolcpus" boot parameter is considered deprecated in linux kernel documentation [0].

[0] https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=isolcpus

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

PASSED: Continuous integration, rev:a8dcc9e4187d856c1c662983c31a7714666b7be6
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/27/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1166/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1587/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/27//rebuild

review: Approve (continuous-integration)

[Mert Kirpici (mertkirpici)]

thanks Ray. I think there are a couple typos in the message that you might want to fix and I left a non-blocking suggestion inline. Once the typos are fixed, it is a +1 from me.

review: Approve

[Gabriel Cocenza (gabrielcocenza)]

Thanks for the patch. I've left some comments bellow.

review: Needs Fixing

[Chi Wai CHAN (raychan96)]

Thanks for the suggestions, I have left some replied in the previous comment.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

PASSED: Continuous integration, rev:a521614259f76e5b0c7c6b7d6c4d6ec03901b292
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/28/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1167/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1588/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/28//rebuild

review: Approve (continuous-integration)

[Eric Chen (eric-chen)]

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 7622096e3fb4e1fdfdf3c9615b29927f7df71ee7

diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
index 8abd854..60726d0 100644
--- a/contrib/canonical-rules.yaml
+++ b/contrib/canonical-rules.yaml
@@ -47,6 +47,12 @@ openstack config:
  sysconfig:
   governor:
    eq: "performance"
+  isolcpus:
+   eq: ""
+   custom-message:
+     isolcpus is deprecated as mentioned in the linux kernel documentation.
+     You are advised to use cpu-affinity-range to achieve similar feature.
+   log-level: warning
  ovn-central:
   ovsdb-server-election-timer:
    gte: 4
diff --git a/contrib/includes/openstack.yaml b/contrib/includes/openstack.yaml
index 86af4da..e0b0f8d 100644
--- a/contrib/includes/openstack.yaml
+++ b/contrib/includes/openstack.yaml
@@ -30,6 +30,13 @@ openstack config base: &openstack-config-base
   sysconfig:
     governor:
       eq: "performance"
+    isolcpus:
+      eq: ""
+      custom-message:
+        isolcpus is deprecated as mentioned in the linux kernel documentation.
+        You are advised to use cpu-affinity-range to achieve similar feature.
+      log-level: warning
+
 
 openstack config:
   << : [ *openstack-config-base, *openstack-config-networking, *openstack-config-database ]