~gabrielcocenza/juju-lint:bug/1979382

Branch merges

Propose for merging

Merged into juju-lint:master at revision ca71a604c57b0c9641780b7cfa48d7e3a39d75c0

Martin Kalcok (community): Approve on 2022-07-20

Eric Chen: Approve on 2022-07-19

Diff: 138 lines (+55/-14)

3 files modified

jujulint/check_spaces.py (+15/-6)
jujulint/lint.py (+2/-1)
tests/test_jujulint.py (+38/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

f03505a... by Gabriel Cocenza on 2022-07-08

warning for applications from other model

- added default alpha space binding for applications that are
  present in the bundle, but miss 'bindings' keyword;
- check if both spaces in a endpoint are not from another model
  to add as mismatch;
- warn log for possible multi-model applications that appear on relations.

Closes-Bug: #1979382
Co-authored-by: Vern Hart <email address hidden>

e5d34a5... by Martin Kalcok on 2022-06-30

Add warnings if bundle does not specify explicit bindings

Reviewed-on: https://code.launchpad.net/~martin-kalcok/juju-lint/+git/juju-lint/+merge/424775
Reviewed-by: Gabriel Angelo Sgarbi Cocenza <email address hidden>

dba0d2d... by Gabriel Cocenza on 2022-06-28

build the snap with local repository.

- source-type git ends up using the code from the master branch
instead of using the local repo as expected.

- added git in stage-packages because otherwise the snap fails to
build.

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/juju-lint/+git/juju-lint/+merge/425412
Reviewed-by: Eric Chen <email address hidden>

f005001... by Gabriel Cocenza on 2022-06-24

build the snap with local repository.

- source-type git ends up using the code from the master branch
instead of using the local repo as expected.

- added git in stage-packages because otherwise the snap fails to
build.

d8625c2... by Gabriel Cocenza on 2022-06-24

Fix to have the snap working on bionic and jammy.

core20 need to have python libs on stage-packages in order to work
on jammy and bionic series.

Reviewed-on: https://code.launchpad.net/~juju-linters/juju-lint/+git/juju-lint/+merge/425333
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: Eric Chen <email address hidden>

d2ce33f... by Gabriel Cocenza on 2022-06-23

Fix to have the snap working on bionic and jammy.

core20 need to have python libs on stage-packages in order to work
on jammy and bionic series.

ce3847e... by Martin Kalcok on 2022-06-22

Merge branch 'master' into warn_on_missing_binding

14ad2b7... by Gabriel Cocenza on 2022-06-17

update the snap

- added black to format the source code of the project and
  applied it into the code.
- added isort to order imports and applied it into the code.
- changed python version from 3.6(deprecated) to 3.8.
- changed base to core20.
- added /snap/bin to $PATH
- removed Pipfile, Pipfile.lock and .python-version that is not
  been used anymore.

Reviewed-on: https://code.launchpad.net/~juju-linters/juju-lint/+git/juju-lint/+merge/424672
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Martin Kalcok <email address hidden>

9b849f2... by Martin Kalcok on 2022-06-16

Verify that at least 1 application has bindings before running "check_spaces()"

57cd095... by Gabriel Cocenza on 2022-06-15

- added black profile in isort
- fixed mixed tab and spaces on tox.ini