Merge ~gabrielcocenza/juju-lint:bug/1979696 into juju-lint:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Eric Chen
Approved revision: f005001b5c12a395beea15bee38741871632cb3c
Merged at revision: dba0d2d9441dccad3a5844a75e536a4c92d2c670
Proposed branch: ~gabrielcocenza/juju-lint:bug/1979696
Merge into: juju-lint:master
Diff against target: 20 lines (+1/-1)
1 file modified
snap/snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Eric Chen Approve
Review via email: mp+425412@code.launchpad.net

Commit message

build the snap with local repository.

- source-type git ends up using the code from the master branch
instead of using the local repo as expected.

- added git in stage-packages because otherwise the snap fails to
build.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dba0d2d9441dccad3a5844a75e536a4c92d2c670

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 69b6b71..156bb68 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -21,7 +21,6 @@ parts:
6 requirements:
7 - requirements.txt
8 source: .
9- source-type: git
10 # Classic core20 snaps require staged python.
11 python-packages: [pip, setuptools, wheel]
12 stage-packages:
13@@ -36,6 +35,7 @@ parts:
14 - python3-setuptools
15 - python3-venv
16 - python3-wheel
17+ - git
18 override-build: |
19 snapcraftctl build
20 echo "Version: $(python3 setup.py --version)"

Subscribers

People subscribed via source and target branches