- ubiquitous relation rule to ensure every machine has a charm unit on it.
- added ubiquitous relation rule to nrpe, telegraf, filebeat, landscape-client
and ubuntu-advantage.
- added a new model input module that is responsible to differentiate the
type of input (Juju Status, Juju Bundle). The input object encapsulate
all mapping and queries necessary against a file.
The idea behind this change is to separate the requirements to avoid
installing redundant packages for each different testing/linting
environment that we are using during a regular development cycle.
Also now we are getting rid of preparing the dev-environment and
installing pre-commit via virtualenv and moving this operation inside
tox.ini which all the other virtual environments are residing, relieving
the Makefile of this duty.
After the renaming process in 30066d3b, makefile dev-environment target
was overlooked, ending up with the broken target. This change is fixing
that also.
Since this issue[0] is resolved, unpinned the flake8 version.
The .venv/ created by dev-environment was not ignored by git, fixed
that.
Using two different command line arguments for the same feature was a
bit confusing. Especially the command line option --dump-state was used
as a boolean flag however it expected a no-op argument to be passed. The
new behavior will gladly accept any number of arguments including zero
and do nothing with them except for printing a deprecation notice.
Dumping the cloud state will be activated by the --output-dir option
only.
We move from this usage:
$ juju-lint --dump-state NOOP_ARG --output-dir DIR ...
to this:
$ juju-lint --output-dir DIR ...
Also during the investigation of this issue, another issue was observed.
This option suggests in its help text that the lint reports are also
going to be written to the output directory, however in the resulting
output they were absent. Another launchpad issue is filed about this and
the "lint reports" part is taken out of the help text for now, to not to
confuse the user.
This change also adds a check for the existence and write access to the
directory before running any linting.
Closes-bug: #1987951
Signed-off-by: Mert Kırpıcı <email address hidden>
