Merge ~mertkirpici/juju-lint:lp/1979686 into juju-lint:master

[Mert Kirpici]

Close LP #1979686

Since the functional tests require the juju-lint application to be
installed to the system, there are two modes of running the tests:
installing the python package to the .tox environment or installing the
snap directly into the system and removing it afterwards. It is worth
mentioning that since `snap install` requires elevated privileges, in
the snap installation case, the pytest fixture install_package() that is
responsible for installing the package will call `sudo install...` and
`sudo remove ...` __requiring passwordless sudo access for the current
user__. The reason for this behaviour rather than enforcing an EUID of
zero is due to the fact that we need access to the user's juju
environment, not root's. Here are examples of both use cases.

Installing the python package:

  $ make functional

Installing the snap:

  $ JUJULINT_TEST_SNAP=./juju-lint_1.0.3_amd64.snap make functional

note the environment variable here. Also note that when the tests are
running against the python package, a WARNING level log will be printed
during the test run to indicate this fact, however when the snap package
is installed, there will be no WARNING printed.

Currently tests are divided into two cases and accompanying markers to
be able to run a subset of them. This might especially come in handy for
skipping the cloud tests during a development cycle since they involve
spinning up a model, deploying an application and destruction of the
model each time the tests are run.

Here is a summary of the two test cases.

- smoke
  - post-build tests as well as tests running against the
    fcb-yoga-focal-bundle.yaml file generated using the
    fcb/sku/stable-yoga-focal branch of the fce-templates repository
- cloud
  - tests that are running against a live model deployed on the local
    cloud via pytest-operator

Combined with the FUNC_ARGS environment variable, these markers could be
used to select tests. Here is an example that runs only the smoke tests:

  $ FUNC_ARGS="-m smoke" make functional

Here is another example utilizing exclusion, since the number of cases
might increase in the future:

  $ FUNC_ARGS="-m 'not cloud'" make functional

[Robert Gildein (rgildein)]

Couple of comments.

[Mert Kirpici (mertkirpici)]

Addressed Robert's comments and submitting for review.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Mert Kirpici (mertkirpici)]

Here is the very first run of the functional tests:
https://pastebin.ubuntu.com/p/3JbcT8F9vk/

[Eric Chen (eric-chen)]

This is a big commit. Could you provide summary of modification? I think we also need to provide this kind of information in launchpad.

e.g.

1. What is the scope of functional tests you focus on? How did you design it?2.
2. Design detail - How to decide the bundle file?

review: Needs Information

[Mert Kirpici (mertkirpici)]

Resubmitting with these changes:

- Updated the commit message and description
- Introduced pytest marks and FUNC_ARGS variable
- Squashed commits for tidiness

Here is the functest run:
https://pastebin.ubuntu.com/p/QztnK5kmcH/

it includes both snap and python package use cases.

[Gabriel Cocenza (gabrielcocenza)]

Great job. Thanks for this patch.
Here are some suggestions:

- I think it would be beneficial if some commands are encapsulated into the .tox and/or makefile.

- I see as possible enhancement is to have more than one option as functional tests in the .tox file. E.g: [testenv:func] to build and install the snap locally and run all functional tests, [testenv:func-smoke] to run tests marked as smoke, [testenv:func-dev] run tests using the python package.

- It will be good to have a small session under Developing in the CONTRIBUTING.md with some explanation on how to run the different functional tests (python package, snap, smoke etc).

I also detected a strange behavior [0] when passing the JUJULINT_TEST_SNAP is returning 120 on subprocess check_call, but check_output seems to work normally.

[0] https://pastebin.canonical.com/p/YDYXwwRH4v/

review: Needs Fixing

[Eric Chen (eric-chen)]

LTGM, just have a question below.

[Mert Kirpici (mertkirpici)]

Rebased the branch on master after the unit test changes. Resolved conflicts. Addressed the review comments.
Updates include:

- add tox environments func-dev and func-smoke for development purposes
- introduce rename.sh like the charms, `make functional` installs snap and runs the functional tests now
- update CONTRIBUTING.md with functional test info
- fixtures not-requiring cleanup return, do not yield anymore
- move the fcb bundle file under common resources for testing
- fix test_audit_local_cloud. there was an invocation error.

See commit messages for more info.

`make test` output:
https://pastebin.ubuntu.com/p/HVrZzpCnBB/

[Gabriel Cocenza (gabrielcocenza)]

LGTM. Thanks!

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 832f001796ca2e1b15777dfc01d47b6260caa0c2

diff --git a/.gitignore b/.gitignore
index 6b085ea..764c99f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,7 +13,7 @@ __pycache__
 *.egg-info
 
 # test artefacts
-tests/report
+tests/unit/report
 .coverage
 
 # debuild cruft
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 1e5c9b9..ef0a32c 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -53,6 +53,17 @@ make test            # run lint, unittests and functional
 make build           # build the snap
 make clean           # clean the snapcraft lxd containers and the snap files created
 ```
+### Functional Tests
+
+`make functional` will build the snap, rename it, install it locally and run the tests against the installed snap package. Since this action involves installing a snap package, passwordless `sudo` privileges are needed.  
+However for development purposes, the testing infrastructure also allows for installing `juju-lint` as a python package to a tox environment
+and running tests against it.  
+In order to invoke:
+- development smoke suite, which deselects tests running against a live lxd cloud
+  - `$ tox -e func-smoke`
+- development full suite, which runs all the functional tests
+  - `$ tox -e func-dev`
+
 
 ## Canonical Contributor Agreement
 
diff --git a/Makefile b/Makefile
index 49303b3..4857f3f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,3 +1,7 @@
+PROJECTPATH=$(dir $(realpath ${MAKEFILE_LIST}))
+SNAP_NAME=$(shell cat ${PROJECTPATH}/snap/snapcraft.yaml | grep -E '^name:' | awk '{print $$2}')
+SNAP_FILE=${PROJECTPATH}/${SNAP_NAME}.snap
+
 help:
 	@echo "This project supports the following targets"
 	@echo ""
@@ -13,7 +17,6 @@ help:
 	@echo " make pre-commit - run pre-commit checks on all the files"
 	@echo ""
 
-
 lint:
 	@echo "Running lint checks"
 	@tox -e lint
@@ -32,6 +35,7 @@ reformat:
 build:
 	@echo "Building the snap"
 	@snapcraft --use-lxd
+	@bash -c ./rename.sh
 
 clean:
 	@echo "Cleaning snap"
@@ -47,7 +51,7 @@ dev-environment:
 
 functional: build
 	@echo "Executing functional tests using built snap"
-	@tox -e func
+	@JUJULINT_TEST_SNAP=${SNAP_FILE} tox -e func -- ${FUNC_ARGS}
 
 pre-commit:
 	@tox -e pre-commit
diff --git a/rename.sh b/rename.sh
new file mode 100755
index 0000000..f7316d0
--- /dev/null
+++ b/rename.sh
@@ -0,0 +1,13 @@
+#!/bin/bash
+snap=$(grep -E "^name:" snap/snapcraft.yaml | awk '{print $2}')
+echo "renaming ${snap}_*.snap to ${snap}.snap"
+echo -n "pwd: "
+pwd
+ls -al
+echo "Removing previous snap if it exists"
+if [[ -e "${snap}.snap" ]];
+then
+    rm "${snap}.snap"
+fi
+echo "Renaming charm here."
+mv ${snap}_*.snap ${snap}.snap
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
new file mode 100644
index 0000000..d26b318
--- /dev/null
+++ b/tests/functional/conftest.py
@@ -0,0 +1,129 @@
+"""Pytest configuration file for juju-lint tests."""
+import logging
+import os
+import shutil
+from subprocess import check_call, check_output
+from textwrap import dedent
+
+import pytest
+
+
+def pytest_configure(config):
+    """Pytest configuration."""
+    config.addinivalue_line("markers", "smoke: mark test as a smoke test")
+    config.addinivalue_line("markers", "cloud: mark test as a cloud test")
+
+
[e-mail](scope="session", autouse=True)
+def install_package():
+    """Install the package to the system and cleanup afterwards.
+
+    Depending on the environment variable JUJULINT_TEST_SNAP,
+    it will install the snap or the python package.
+    """
+    jujulint_test_snap = os.environ.get("JUJULINT_TEST_SNAP", None)
+    if jujulint_test_snap:
+        logging.info(f"Installing {jujulint_test_snap}")
+        assert os.path.isfile(jujulint_test_snap)
+        assert (
+            check_call(
+                f"sudo snap install --dangerous --classic {jujulint_test_snap}".split()
+            )
+            == 0  # noqa
+        )
+        assert check_output("which juju-lint".split()).decode().strip() == os.path.join(
+            "/snap/bin/juju-lint"
+        )
+    else:
+        logging.warning("Installing python package")
+        assert check_call("python3 -m pip install .".split()) == 0
+        assert (
+            check_output("which juju-lint".split())
+            .decode()
+            .strip()
+            .startswith(os.path.join(os.getcwd(), ".tox"))
+        )
+
+    yield jujulint_test_snap
+
+    if jujulint_test_snap:
+        logging.info("Removing snap package juju-lint")
+        check_call("sudo snap remove juju-lint".split())
+    else:
+        logging.info("Uninstalling python package jujulint")
+        check_call("python3 -m pip uninstall --yes jujulint".split())
+
+
[e-mail]
+def basedir():
+    """Return the basedir for the installation.
+
+    This will ease testing the rules files that we ship
+    with the juju-lint snap.
+    """
+    if os.environ.get("JUJULINT_TEST_SNAP", None):
+        basedir = "/snap/juju-lint/current/"
+    else:
+        basedir = os.getcwd()
+    return basedir
+
+
[e-mail]
+def rules_file(basedir):
+    """Return the rules file for testing."""
+    return os.path.join(basedir, "contrib/fcb-yoga-focal.yaml")
+
+
[e-mail]
+def manual_file():
+    """Return the bundle file for testing."""
+    return os.path.join(
+        os.path.dirname(__file__), "../resources/fcb-yoga-focal-bundle.yaml"
+    )
+
+
[e-mail]
+def lint_rules_yaml(basedir, rules_file):
+    """Return the default lint-rules.yaml file and cleanup."""
+    lint_rules_yaml_file = os.path.join(os.getcwd(), "lint-rules.yaml")
+    shutil.copy(rules_file, lint_rules_yaml_file)
+
+    includes_dir = os.path.join(os.getcwd(), "includes")
+    os.symlink(os.path.join(basedir, "contrib/includes"), includes_dir)
+
+    yield lint_rules_yaml_file
+
+    os.unlink(lint_rules_yaml_file)
+    os.unlink(includes_dir)
+
+
[e-mail]
+def local_cloud():
+    """Prepare the local configuration file for juju-lint.
+
+    If there's an existing configuration directory, back it up
+    first and then recover.
+    """
+    local_cloud_name = "test"
+    backup = False
+    local_config_dir = os.path.join(os.path.expanduser("~"), ".config/juju-lint")
+    local_config_file = os.path.join(local_config_dir, "config.yaml")
+    if os.path.isdir(local_config_dir):
+        logging.info("Backing up existing config directory")
+        shutil.move(local_config_dir, local_config_dir + ".bak")
+        backup = True
+    os.makedirs(local_config_dir)
+    with open(local_config_file, "w") as config_yaml:
+        config_yaml_str = f"""\
+            clouds:
+              {local_cloud_name}:
+                type: openstack
+            """
+        config_yaml.write(dedent(config_yaml_str))
+
+    yield local_cloud_name
+
+    shutil.rmtree(local_config_dir)
+    if backup:
+        logging.info("Restoring backup")
+        shutil.move(local_config_dir + ".bak", local_config_dir)
diff --git a/tests/functional/requirements.txt b/tests/functional/requirements.txt
new file mode 100644
index 0000000..2220b6c
--- /dev/null
+++ b/tests/functional/requirements.txt
@@ -0,0 +1 @@
+pytest-operator
\ No newline at end of file
diff --git a/tests/functional/test_jujulint.py b/tests/functional/test_jujulint.py
new file mode 100644
index 0000000..e15e9b6
--- /dev/null
+++ b/tests/functional/test_jujulint.py
@@ -0,0 +1,49 @@
+"""Functional tests for juju-lint."""
+import json
+import socket
+from subprocess import check_call, check_output
+
+import pytest
+
+
[e-mail]
+def test_juju_lint_startup():
+    """Test starting juju-lint and print help string."""
+    assert check_call("juju-lint --help".split()) == 0
+
+
[e-mail]
+def test_load_rules_file_from_path(rules_file, manual_file):
+    """Test loading the rules file via command line argument."""
+    assert check_call(f"juju-lint -c {rules_file} {manual_file}".split()) == 0
+
+
[e-mail]
+def test_load_default_rules_file(lint_rules_yaml, manual_file):
+    """Test loading the default rules file."""
+    assert check_call(f"juju-lint {manual_file}".split()) == 0
+
+
[e-mail]
+def test_json_output(rules_file, manual_file):
+    """Test json output."""
+    assert json.loads(
+        check_output(
+            f"juju-lint --format json -c {rules_file} {manual_file}".split()
+        ).decode()
+    )
+
+
[e-mail]
+async def test_audit_local_cloud(ops_test, local_cloud, rules_file):
+    """Test running juju-lint against a live local cloud."""
+    await ops_test.model.deploy("ubuntu")
+    await ops_test.model.wait_for_idle()
+    returncode, stdout, stderr = await ops_test.run(
+        *f"juju-lint -c {rules_file}".split()
+    )
+    assert (
+        f"[{local_cloud}] Linting model information for {socket.getfqdn()}, "
+        f"controller {ops_test.controller_name}, model {ops_test.model_name}" in stderr
+    )
+    assert returncode == 0
diff --git a/tests/resources/fcb-yoga-focal-bundle.yaml b/tests/resources/fcb-yoga-focal-bundle.yaml
new file mode 100644
index 0000000..de6364c
--- /dev/null
+++ b/tests/resources/fcb-yoga-focal-bundle.yaml
@@ -0,0 +1,1442 @@
+applications:
+  aodh:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: aodh
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  aodh-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  barbican:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      secrets: internal-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: barbican
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  barbican-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  barbican-vault:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      secrets: internal-space
+      secrets-storage: internal-space
+    channel: yoga/stable
+    charm: barbican-vault
+  bcache-tuning:
+    bindings:
+      ? ''
+      : oam-space
+    charm: bcache-tuning
+  canonical-livepatch:
+    bindings:
+      ? ''
+      : oam-space
+    charm: canonical-livepatch
+    options:
+      livepatch_key: FCE_TEMPLATE
+  ceilometer:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-credentials: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: ceilometer
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  ceilometer-agent:
+    bindings:
+      ? ''
+      : oam-space
+      amqp: internal-space
+    channel: yoga/stable
+    charm: ceilometer-agent
+    options:
+      use-internal-endpoints: true
+  ceph-dashboard:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+    channel: quincy/stable
+    charm: ceph-dashboard
+    options:
+      grafana-api-url: https://grafana.maas:3000
+  ceph-mon:
+    bindings:
+      ? ''
+      : oam-space
+      admin: ceph-access-space
+      client: ceph-access-space
+      cluster: ceph-replica-space
+      osd: ceph-access-space
+      public: ceph-access-space
+      radosgw: ceph-access-space
+    channel: quincy/stable
+    charm: ceph-mon
+    num_units: 3
+    options:
+      customize-failure-domain: true
+      expected-osd-count: FCE_TEMPLATE
+      source: cloud:focal-yoga
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  ceph-osd:
+    bindings:
+      ? ''
+      : oam-space
+      cluster: ceph-replica-space
+      mon: ceph-access-space
+      public: ceph-access-space
+      secrets-storage: internal-space
+    channel: quincy/stable
+    charm: ceph-osd
+    num_units: 9
+    options:
+      aa-profile-mode: complain
+      autotune: false
+      bluestore: true
+      customize-failure-domain: true
+      osd-devices: /dev/disk/by-dname/FCE_TEMPLATE
+      osd-encrypt: true
+      osd-encrypt-keymanager: vault
+      source: cloud:focal-yoga
+    to:
+    - '0'
+    - '1'
+    - '2'
+    - '3'
+    - '4'
+    - '5'
+    - '6'
+    - '7'
+    - '8'
+  ceph-radosgw:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      mon: ceph-access-space
+      public: public-space
+    channel: quincy/stable
+    charm: ceph-radosgw
+    constraints: spaces=ceph-access-space
+    num_units: 3
+    options:
+      region: RegionOne
+      source: cloud:focal-yoga
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  cinder:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: cinder
+    constraints: spaces=ceph-access-space
+    num_units: 3
+    options:
+      block-device: None
+      glance-api-version: 2
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  cinder-ceph:
+    bindings:
+      ? ''
+      : oam-space
+      ceph: ceph-access-space
+    channel: yoga/stable
+    charm: cinder-ceph
+  cinder-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  designate:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      coordinator-memcached: internal-space
+      dns-backend: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: designate
+    num_units: 3
+    options:
+      nameservers: FCE_TEMPLATE
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  designate-bind:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      dns-backend: internal-space
+      dns-frontend: oam-space
+    channel: yoga/stable
+    charm: designate-bind
+    num_units: 2
+    options:
+      allowed_nets: FCE_TEMPLATE
+      disable-dnssec-validation: true
+      forwarders: FCE_TEMPLATE
+      recursion: true
+      use-internal-endpoints: true
+    to:
+    - memcached/0
+    - memcached/1
+  designate-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  easyrsa:
+    bindings:
+      ? ''
+      : oam-space
+      client: internal-space
+    charm: easyrsa
+    num_units: 1
+    to:
+    - lxd:6
+  etcd:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      db: internal-space
+    charm: etcd
+    num_units: 3
+    options:
+      channel: 3.4/stable
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  filebeat:
+    bindings:
+      ? ''
+      : oam-space
+    charm: filebeat
+    options:
+      logpath: /var/log/*.log
+  glance:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      ceph: ceph-access-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: glance
+    constraints: spaces=ceph-access-space
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  glance-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  glance-simplestreams-sync:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      identity-service: internal-space
+    channel: yoga/stable
+    charm: glance-simplestreams-sync
+    num_units: 1
+    options:
+      mirror_list: '[{ url: "http://cloud-images.ubuntu.com/releases/", name_prefix:
+        "ubuntu:released", path: "streams/v1/index.sjson", max: 1, item_filters: ["release~(bionic|focal)",
+        "arch~(x86_64|amd64)", "ftype~(disk1.img|disk.img)"] }]'
+      region: RegionOne
+    to:
+    - lxd:7
+  gnocchi:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      coordinator-memcached: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+      storage-ceph: ceph-access-space
+    channel: yoga/stable
+    charm: gnocchi
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  gnocchi-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  hacluster-aodh:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-barbican:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-ceilometer:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-ceph-radosgw:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-cinder:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-designate:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-glance:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-gnocchi:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-heat:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-keystone:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-neutron-api:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-nova-cloud-controller:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-octavia:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-openstack-dashboard:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-placement:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  hacluster-vault:
+    bindings:
+      ? ''
+      : oam-space
+    channel: 2.0.3/stable
+    charm: hacluster
+    options:
+      cluster_count: 3
+  heat:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: heat
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  heat-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  homer-dashboard:
+    bindings:
+      ? ''
+      : oam-space
+      application-dashboard: public-space
+    charm: bootstack-charmers-homer-dashboard
+    num_units: 1
+    to:
+    - lxd:8
+  keystone:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      certificates: internal-space
+      identity-credentials: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: keystone
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      preferred-api-version: 3
+      region: RegionOne
+      token-expiration: 86400
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  keystone-ldap:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+    channel: yoga/stable
+    charm: keystone-ldap
+    options:
+      domain-name: FCE_TEMPLATE
+      ldap-config-flags: FCE_TEMPLATE
+      ldap-password: FCE_TEMPLATE
+      ldap-server: FCE_TEMPLATE
+      ldap-suffix: FCE_TEMPLATE
+      ldap-user: FCE_TEMPLATE
+  keystone-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  landscape-client:
+    bindings:
+      ? ''
+      : oam-space
+    charm: landscape-client
+    options:
+      account-name: standalone
+      disable-unattended-upgrades: true
+      ping-url: FCE_TEMPLATE
+      ssl-public-key: FCE_TEMPLATE
+      url: FCE_TEMPLATE
+  lldpd:
+    bindings:
+      ? ''
+      : oam-space
+    charm: lldpd
+    options:
+      interfaces-regex: en*
+  logrotated:
+    bindings:
+      ? ''
+      : oam-space
+    charm: logrotated
+    options:
+      logrotate-retention: 60
+  memcached:
+    bindings:
+      ? ''
+      : oam-space
+      cache: internal-space
+    charm: memcached
+    num_units: 2
+    options:
+      allow-ufw-ip6-softfail: true
+    to:
+    - lxd:3
+    - lxd:6
+  mysql-innodb-cluster:
+    bindings:
+      ? ''
+      : oam-space
+      cluster: internal-space
+      db-router: internal-space
+    channel: 8.0/stable
+    charm: mysql-innodb-cluster
+    num_units: 3
+    options:
+      enable-binlogs: true
+      innodb-buffer-pool-size: 8G
+      max-connections: 4000
+      wait-timeout: 3600
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  neutron-api:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: neutron-api
+    num_units: 3
+    options:
+      dns-domain: FCE_TEMPLATE
+      enable-ml2-dns: true
+      enable-ml2-port-security: true
+      flat-network-providers: ''
+      global-physnet-mtu: 9000
+      manage-neutron-plugin-legacy-mode: false
+      neutron-security-groups: true
+      openstack-origin: cloud:focal-yoga
+      path-mtu: 1558
+      physical-network-mtus: FCE_TEMPLATE
+      region: RegionOne
+      use-internal-endpoints: true
+      vlan-ranges: FCE_TEMPLATE
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  neutron-api-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  neutron-api-plugin-ovn:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+    channel: yoga/stable
+    charm: neutron-api-plugin-ovn
+  nova-cloud-controller:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      cloud-compute: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      memcache: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: nova-cloud-controller
+    num_units: 3
+    options:
+      console-access-protocol: spice
+      cpu-allocation-ratio: 16
+      network-manager: Neutron
+      openstack-origin: cloud:focal-yoga
+      ram-allocation-ratio: 1.0
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  nova-cloud-controller-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  nova-compute:
+    bindings:
+      ? ''
+      : oam-space
+      amqp: internal-space
+      ceph: ceph-access-space
+      cloud-compute: internal-space
+      internal: internal-space
+      migration: internal-space
+      secrets-storage: internal-space
+    channel: yoga/stable
+    charm: nova-compute
+    num_units: 9
+    options:
+      aa-profile-mode: enforce
+      cpu-mode: custom
+      cpu-model: FCE_TEMPLATE
+      customize-failure-domain: true
+      enable-live-migration: true
+      enable-resize: true
+      encrypt: true
+      ephemeral-device: /dev/disk/by-dname/FCE_TEMPLATE
+      openstack-origin: cloud:focal-yoga
+      reserved-host-memory: 16384
+      use-internal-endpoints: true
+    to:
+    - '0'
+    - '1'
+    - '2'
+    - '3'
+    - '4'
+    - '5'
+    - '6'
+    - '7'
+    - '8'
+  nrpe:
+    bindings:
+      ? ''
+      : oam-space
+    charm: nrpe
+  ntp:
+    bindings:
+      ? ''
+      : oam-space
+    charm: ntp
+    options:
+      pools: 0.ubuntu.pool.ntp.org 1.ubuntu.pool.ntp.org 2.ubuntu.pool.ntp.org 3.ubuntu.pool.ntp.org
+        ntp.ubuntu.com
+      source: ''
+      verify_ntp_servers: true
+  octavia:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: octavia
+    num_units: 3
+    options:
+      lb-mgmt-controller-cacert: FCE_TEMPLATE
+      lb-mgmt-controller-cert: FCE_TEMPLATE
+      lb-mgmt-issuing-ca-key-passphrase: FCE_TEMPLATE
+      lb-mgmt-issuing-ca-private-key: FCE_TEMPLATE
+      lb-mgmt-issuing-cacert: FCE_TEMPLATE
+      loadbalancer-topology: ACTIVE_STANDBY
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  octavia-dashboard:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      dashboard: public-space
+    channel: yoga/stable
+    charm: octavia-dashboard
+  octavia-diskimage-retrofit:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      identity-credentials: internal-space
+    channel: yoga/stable
+    charm: octavia-diskimage-retrofit
+    options:
+      amp-image-tag: octavia-amphora
+      retrofit-uca-pocket: ussuri
+  octavia-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  octavia-ovn-chassis:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      data: internal-space
+    channel: 22.03/stable
+    charm: ovn-chassis
+    options:
+      disable-mlockall: true
+      ovn-bridge-mappings: FCE_TEMPLATE
+  openstack-dashboard:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      dashboard-plugin: public-space
+      identity-service: internal-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: openstack-dashboard
+    num_units: 3
+    options:
+      endpoint-type: publicURL
+      neutron-network-l3ha: true
+      neutron-network-lb: true
+      openstack-origin: cloud:focal-yoga
+      password-retrieve: true
+      secret: FCE_TEMPLATE
+      webroot: /
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  openstack-dashboard-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  openstack-service-checks:
+    bindings:
+      ? ''
+      : oam-space
+      identity-credentials: internal-space
+    charm: openstack-service-checks
+    num_units: 1
+    options:
+      s3_check_params: /
+    to:
+    - lxd:1
+  ovn-central:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+    channel: 22.03/stable
+    charm: ovn-central
+    num_units: 3
+    options:
+      source: cloud:focal-yoga
+    to:
+    - lxd:0
+    - lxd:3
+    - lxd:6
+  ovn-chassis:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      data: internal-space
+    channel: 22.03/stable
+    charm: ovn-chassis
+    options:
+      bridge-interface-mappings: br-data:FCE_TEMPLATE
+      ovn-bridge-mappings: FCE_TEMPLATE
+  placement:
+    bindings:
+      ? ''
+      : oam-space
+      admin: internal-space
+      amqp: internal-space
+      certificates: internal-space
+      identity-service: internal-space
+      internal: internal-space
+      public: public-space
+      shared-db: internal-space
+    channel: yoga/stable
+    charm: placement
+    num_units: 3
+    options:
+      openstack-origin: cloud:focal-yoga
+      region: RegionOne
+      use-internal-endpoints: true
+    to:
+    - lxd:1
+    - lxd:4
+    - lxd:7
+  placement-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+  prometheus-libvirt-exporter:
+    bindings:
+      ? ''
+      : oam-space
+    charm: prometheus-libvirt-exporter
+  prometheus-openstack-exporter:
+    bindings:
+      ? ''
+      : oam-space
+      identity-credentials: internal-space
+      prometheus-openstack-exporter-service: oam-space
+    charm: prometheus-openstack-exporter
+    num_units: 1
+    options:
+      cpu-allocation-ratio: 16
+      ram-allocation-ratio: 1.0
+    to:
+    - lxd:0
+  public-policy-routing:
+    bindings:
+      ? ''
+      : oam-space
+    charm: advanced-routing
+    options:
+      action-managed-update: false
+      advanced-routing-config: "[{\n    # NOTE: remove comments afterwards, result\
+        \ must be a valid JSON\n    \"type\": \"table\",\n    \"table\": \"public\"\
+        \n},{\n    \"type\": \"route\",\n    \"default_route\": true,\n    \"gateway\"\
+        : \"FCE_TEMPLATE\",  # Replace to gateway address of public network\n    \"\
+        table\": \"public\",\n    \"metric\": \"101\"\n},{\n    \"type\": \"rule\"\
+        ,\n    \"from-net\": \"FCE_TEMPLATE\", # Replace to CIDR of public network\n\
+        \    \"table\": \"public\",\n    \"priority\": \"101\"\n},{\n    \"type\"\
+        : \"rule\",\n    \"from-net\": \"FCE_TEMPLATE\", # Replace to CIDR of public\
+        \ network\n    \"to-net\": \"FCE_TEMPLATE\"    # Replace to CIDR of public\
+        \ network\n}]"
+      enable-advanced-routing: true
+  rabbitmq-server:
+    bindings:
+      ? ''
+      : oam-space
+      amqp: internal-space
+      cluster: internal-space
+    channel: 3.9/stable
+    charm: rabbitmq-server
+    num_units: 3
+    options:
+      cluster-partition-handling: pause_minority
+      min-cluster-size: 3
+      source: cloud:focal-yoga
+    to:
+    - lxd:2
+    - lxd:5
+    - lxd:8
+  telegraf:
+    bindings:
+      ? ''
+      : oam-space
+    charm: telegraf
+  vault:
+    bindings:
+      ? ''
+      : oam-space
+      certificates: internal-space
+      etcd: internal-space
+      secrets: internal-space
+      shared-db: internal-space
+    channel: 1.7/stable
+    charm: vault
+    num_units: 3
+    to:
+    - '10'
+    - '11'
+    - '9'
+  vault-mysql-router:
+    bindings:
+      ? ''
+      : oam-space
+      db-router: internal-space
+      shared-db: internal-space
+    channel: latest/edge
+    charm: mysql-router
+machines:
+  '0':
+    constraints: tags=foundation-nodes zones=zone1
+  '1':
+    constraints: tags=foundation-nodes zones=zone1
+  '10':
+    constraints: tags=vault zones=zone2
+  '11':
+    constraints: tags=vault zones=zone3
+  '2':
+    constraints: tags=foundation-nodes zones=zone1
+  '3':
+    constraints: tags=foundation-nodes zones=zone2
+  '4':
+    constraints: tags=foundation-nodes zones=zone2
+  '5':
+    constraints: tags=foundation-nodes zones=zone2
+  '6':
+    constraints: tags=foundation-nodes zones=zone3
+  '7':
+    constraints: tags=foundation-nodes zones=zone3
+  '8':
+    constraints: tags=foundation-nodes zones=zone3
+  '9':
+    constraints: tags=vault zones=zone1
+saas:
+  grafana:
+    url: foundations-maas:admin/lma-maas.grafana
+  graylog:
+    url: foundations-maas:admin/lma-maas.graylog
+  landscape-server:
+    url: foundations-maas:admin/lma-maas.landscape-server
+  nagios:
+    url: foundations-maas:admin/lma-maas.nagios
+  prometheus:
+    url: foundations-maas:admin/lma-maas.prometheus
+series: focal
+relations:
+- ['aodh-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['aodh-mysql-router:shared-db', 'aodh:shared-db']
+- ['aodh:amqp', 'rabbitmq-server:amqp']
+- ['aodh:certificates', 'vault:certificates']
+- ['aodh:ha', 'hacluster-aodh:ha']
+- ['aodh:identity-service', 'keystone:identity-service']
+- ['aodh:juju-info', 'filebeat:beats-host']
+- ['aodh:juju-info', 'landscape-client:container']
+- ['aodh:juju-info', 'logrotated:juju-info']
+- ['aodh:juju-info', 'nrpe:general-info']
+- ['aodh:juju-info', 'public-policy-routing:juju-info']
+- ['aodh:juju-info', 'telegraf:juju-info']
+- ['aodh:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['barbican-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['barbican-mysql-router:shared-db', 'barbican:shared-db']
+- ['barbican-vault:certificates', 'vault:certificates']
+- ['barbican-vault:secrets-storage', 'vault:secrets']
+- ['barbican-vault:secrets', 'barbican:secrets']
+- ['barbican:amqp', 'rabbitmq-server:amqp']
+- ['barbican:certificates', 'vault:certificates']
+- ['barbican:ha', 'hacluster-barbican:ha']
+- ['barbican:identity-service', 'keystone:identity-service']
+- ['barbican:juju-info', 'filebeat:beats-host']
+- ['barbican:juju-info', 'landscape-client:container']
+- ['barbican:juju-info', 'logrotated:juju-info']
+- ['barbican:juju-info', 'nrpe:general-info']
+- ['barbican:juju-info', 'public-policy-routing:juju-info']
+- ['barbican:juju-info', 'telegraf:juju-info']
+- ['bcache-tuning:juju-info', 'ceph-osd:juju-info']
+- ['canonical-livepatch:juju-info', 'ceph-osd:juju-info']
+- ['canonical-livepatch:juju-info', 'vault:juju-info']
+- ['canonical-livepatch:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['ceilometer-agent:amqp', 'rabbitmq-server:amqp']
+- ['ceilometer-agent:ceilometer-service', 'ceilometer:ceilometer-service']
+- ['ceilometer-agent:nova-ceilometer', 'nova-compute:nova-ceilometer']
+- ['ceilometer:amqp', 'rabbitmq-server:amqp']
+- ['ceilometer:certificates', 'vault:certificates']
+- ['ceilometer:ha', 'hacluster-ceilometer:ha']
+- ['ceilometer:identity-credentials', 'keystone:identity-credentials']
+- ['ceilometer:identity-notifications', 'keystone:identity-notifications']
+- ['ceilometer:juju-info', 'filebeat:beats-host']
+- ['ceilometer:juju-info', 'landscape-client:container']
+- ['ceilometer:juju-info', 'logrotated:juju-info']
+- ['ceilometer:juju-info', 'nrpe:general-info']
+- ['ceilometer:juju-info', 'public-policy-routing:juju-info']
+- ['ceilometer:juju-info', 'telegraf:juju-info']
+- ['ceilometer:metric-service', 'gnocchi:metric-service']
+- ['ceilometer:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['ceph-dashboard:certificates', 'vault:certificates']
+- ['ceph-dashboard:dashboard', 'ceph-mon:dashboard']
+- ['ceph-dashboard:grafana-dashboard', 'grafana:dashboards']
+- ['ceph-dashboard:prometheus', 'prometheus:website']
+- ['ceph-mon:client', 'cinder-ceph:ceph']
+- ['ceph-mon:client', 'glance:ceph']
+- ['ceph-mon:client', 'gnocchi:storage-ceph']
+- ['ceph-mon:client', 'nova-compute:ceph']
+- ['ceph-mon:juju-info', 'filebeat:beats-host']
+- ['ceph-mon:juju-info', 'landscape-client:container']
+- ['ceph-mon:juju-info', 'logrotated:juju-info']
+- ['ceph-mon:juju-info', 'nrpe:general-info']
+- ['ceph-mon:juju-info', 'telegraf:juju-info']
+- ['ceph-mon:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['ceph-mon:osd', 'ceph-osd:mon']
+- ['ceph-mon:prometheus', 'prometheus:target']
+- ['ceph-mon:radosgw', 'ceph-radosgw:mon']
+- ['ceph-osd:juju-info', 'filebeat:beats-host']
+- ['ceph-osd:juju-info', 'landscape-client:container']
+- ['ceph-osd:juju-info', 'nrpe:general-info']
+- ['ceph-osd:juju-info', 'ntp:juju-info']
+- ['ceph-osd:juju-info', 'telegraf:juju-info']
+- ['ceph-osd:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['ceph-osd:secrets-storage', 'vault:secrets']
+- ['ceph-radosgw:certificates', 'vault:certificates']
+- ['ceph-radosgw:ha', 'hacluster-ceph-radosgw:ha']
+- ['ceph-radosgw:identity-service', 'keystone:identity-service']
+- ['ceph-radosgw:juju-info', 'filebeat:beats-host']
+- ['ceph-radosgw:juju-info', 'landscape-client:container']
+- ['ceph-radosgw:juju-info', 'logrotated:juju-info']
+- ['ceph-radosgw:juju-info', 'nrpe:general-info']
+- ['ceph-radosgw:juju-info', 'public-policy-routing:juju-info']
+- ['ceph-radosgw:juju-info', 'telegraf:juju-info']
+- ['ceph-radosgw:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['cinder-ceph:ceph-access', 'nova-compute:ceph-access']
+- ['cinder-ceph:storage-backend', 'cinder:storage-backend']
+- ['cinder-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['cinder-mysql-router:shared-db', 'cinder:shared-db']
+- ['cinder:amqp', 'rabbitmq-server:amqp']
+- ['cinder:certificates', 'vault:certificates']
+- ['cinder:ha', 'hacluster-cinder:ha']
+- ['cinder:identity-service', 'keystone:identity-service']
+- ['cinder:image-service', 'glance:image-service']
+- ['cinder:juju-info', 'filebeat:beats-host']
+- ['cinder:juju-info', 'landscape-client:container']
+- ['cinder:juju-info', 'logrotated:juju-info']
+- ['cinder:juju-info', 'nrpe:general-info']
+- ['cinder:juju-info', 'public-policy-routing:juju-info']
+- ['cinder:juju-info', 'telegraf:juju-info']
+- ['cinder:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['designate-bind:certificates', 'vault:certificates']
+- ['designate-bind:dns-backend', 'designate:dns-backend']
+- ['designate-bind:juju-info', 'public-policy-routing:juju-info']
+- ['designate-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['designate-mysql-router:shared-db', 'designate:shared-db']
+- ['designate:amqp', 'rabbitmq-server:amqp']
+- ['designate:certificates', 'vault:certificates']
+- ['designate:coordinator-memcached', 'memcached:cache']
+- ['designate:dnsaas', 'neutron-api:external-dns']
+- ['designate:ha', 'hacluster-designate:ha']
+- ['designate:identity-service', 'keystone:identity-service']
+- ['designate:juju-info', 'filebeat:beats-host']
+- ['designate:juju-info', 'landscape-client:container']
+- ['designate:juju-info', 'logrotated:juju-info']
+- ['designate:juju-info', 'nrpe:general-info']
+- ['designate:juju-info', 'public-policy-routing:juju-info']
+- ['designate:juju-info', 'telegraf:juju-info']
+- ['designate:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['easyrsa:client', 'etcd:certificates']
+- ['easyrsa:juju-info', 'filebeat:beats-host']
+- ['easyrsa:juju-info', 'landscape-client:container']
+- ['easyrsa:juju-info', 'logrotated:juju-info']
+- ['easyrsa:juju-info', 'nrpe:general-info']
+- ['easyrsa:juju-info', 'telegraf:juju-info']
+- ['etcd:db', 'vault:etcd']
+- ['etcd:grafana', 'grafana:dashboards']
+- ['etcd:juju-info', 'filebeat:beats-host']
+- ['etcd:juju-info', 'landscape-client:container']
+- ['etcd:juju-info', 'logrotated:juju-info']
+- ['etcd:juju-info', 'nrpe:general-info']
+- ['etcd:juju-info', 'telegraf:juju-info']
+- ['etcd:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['etcd:prometheus', 'prometheus:manual-jobs']
+- ['filebeat:beats-host', 'glance-simplestreams-sync:juju-info']
+- ['filebeat:beats-host', 'glance:juju-info']
+- ['filebeat:beats-host', 'gnocchi:juju-info']
+- ['filebeat:beats-host', 'heat:juju-info']
+- ['filebeat:beats-host', 'homer-dashboard:juju-info']
+- ['filebeat:beats-host', 'keystone:juju-info']
+- ['filebeat:beats-host', 'memcached:juju-info']
+- ['filebeat:beats-host', 'mysql-innodb-cluster:juju-info']
+- ['filebeat:beats-host', 'neutron-api:juju-info']
+- ['filebeat:beats-host', 'nova-cloud-controller:juju-info']
+- ['filebeat:beats-host', 'octavia:juju-info']
+- ['filebeat:beats-host', 'openstack-dashboard:juju-info']
+- ['filebeat:beats-host', 'openstack-service-checks:juju-info']
+- ['filebeat:beats-host', 'ovn-central:juju-info']
+- ['filebeat:beats-host', 'placement:juju-info']
+- ['filebeat:beats-host', 'prometheus-openstack-exporter:juju-info']
+- ['filebeat:beats-host', 'rabbitmq-server:juju-info']
+- ['filebeat:beats-host', 'vault:juju-info']
+- ['filebeat:logstash', 'graylog:beats']
+- ['glance-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['glance-mysql-router:shared-db', 'glance:shared-db']
+- ['glance-simplestreams-sync:certificates', 'vault:certificates']
+- ['glance-simplestreams-sync:identity-service', 'keystone:identity-service']
+- ['glance-simplestreams-sync:juju-info', 'landscape-client:container']
+- ['glance-simplestreams-sync:juju-info', 'logrotated:juju-info']
+- ['glance-simplestreams-sync:juju-info', 'nrpe:general-info']
+- ['glance-simplestreams-sync:juju-info', 'octavia-diskimage-retrofit:juju-info']
+- ['glance-simplestreams-sync:juju-info', 'telegraf:juju-info']
+- ['glance-simplestreams-sync:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['glance:amqp', 'rabbitmq-server:amqp']
+- ['glance:certificates', 'vault:certificates']
+- ['glance:ha', 'hacluster-glance:ha']
+- ['glance:identity-service', 'keystone:identity-service']
+- ['glance:image-service', 'nova-cloud-controller:image-service']
+- ['glance:image-service', 'nova-compute:image-service']
+- ['glance:juju-info', 'landscape-client:container']
+- ['glance:juju-info', 'logrotated:juju-info']
+- ['glance:juju-info', 'nrpe:general-info']
+- ['glance:juju-info', 'public-policy-routing:juju-info']
+- ['glance:juju-info', 'telegraf:juju-info']
+- ['glance:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['gnocchi-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['gnocchi-mysql-router:shared-db', 'gnocchi:shared-db']
+- ['gnocchi:amqp', 'rabbitmq-server:amqp']
+- ['gnocchi:certificates', 'vault:certificates']
+- ['gnocchi:coordinator-memcached', 'memcached:cache']
+- ['gnocchi:ha', 'hacluster-gnocchi:ha']
+- ['gnocchi:identity-service', 'keystone:identity-service']
+- ['gnocchi:juju-info', 'landscape-client:container']
+- ['gnocchi:juju-info', 'logrotated:juju-info']
+- ['gnocchi:juju-info', 'nrpe:general-info']
+- ['gnocchi:juju-info', 'public-policy-routing:juju-info']
+- ['gnocchi:juju-info', 'telegraf:juju-info']
+- ['grafana:application-dashboard', 'homer-dashboard:application-dashboard']
+- ['grafana:dashboards', 'prometheus-openstack-exporter:dashboards']
+- ['graylog:application-dashboard', 'homer-dashboard:application-dashboard']
+- ['hacluster-aodh:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-barbican:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-ceilometer:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-ceph-radosgw:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-cinder:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-designate:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-glance:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-gnocchi:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-heat:ha', 'heat:ha']
+- ['hacluster-heat:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-keystone:ha', 'keystone:ha']
+- ['hacluster-keystone:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-neutron-api:ha', 'neutron-api:ha']
+- ['hacluster-neutron-api:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-nova-cloud-controller:ha', 'nova-cloud-controller:ha']
+- ['hacluster-nova-cloud-controller:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-octavia:ha', 'octavia:ha']
+- ['hacluster-octavia:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-openstack-dashboard:ha', 'openstack-dashboard:ha']
+- ['hacluster-openstack-dashboard:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-placement:ha', 'placement:ha']
+- ['hacluster-placement:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['hacluster-vault:ha', 'vault:ha']
+- ['hacluster-vault:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['heat-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['heat-mysql-router:shared-db', 'heat:shared-db']
+- ['heat:amqp', 'rabbitmq-server:amqp']
+- ['heat:certificates', 'vault:certificates']
+- ['heat:identity-service', 'keystone:identity-service']
+- ['heat:juju-info', 'landscape-client:container']
+- ['heat:juju-info', 'logrotated:juju-info']
+- ['heat:juju-info', 'nrpe:general-info']
+- ['heat:juju-info', 'public-policy-routing:juju-info']
+- ['heat:juju-info', 'telegraf:juju-info']
+- ['heat:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['homer-dashboard:application-dashboard', 'landscape-server:application-dashboard']
+- ['homer-dashboard:application-dashboard', 'nagios:application-dashboard']
+- ['homer-dashboard:juju-info', 'landscape-client:container']
+- ['homer-dashboard:juju-info', 'logrotated:juju-info']
+- ['homer-dashboard:juju-info', 'nrpe:general-info']
+- ['homer-dashboard:juju-info', 'telegraf:juju-info']
+- ['keystone-ldap:certificates', 'vault:certificates']
+- ['keystone-ldap:domain-backend', 'keystone:domain-backend']
+- ['keystone-mysql-router:db-router', 'mysql-innodb-cluster:db-router']
+- ['keystone-mysql-router:shared-db', 'keystone:shared-db']
+- ['keystone:certificates', 'vault:certificates']
+- ['keystone:identity-credentials', 'octavia-diskimage-retrofit:identity-credentials']
+- ['keystone:identity-credentials', 'openstack-service-checks:identity-credentials']
+- ['keystone:identity-credentials', 'prometheus-openstack-exporter:identity-credentials']
+- ['keystone:identity-notifications', 'openstack-service-checks:identity-notifications']
+- ['keystone:identity-service', 'neutron-api:identity-service']
+- ['keystone:identity-service', 'nova-cloud-controller:identity-service']
+- ['keystone:identity-service', 'octavia:identity-service']
+- ['keystone:identity-service', 'openstack-dashboard:identity-service']
+- ['keystone:identity-service', 'placement:identity-service']
+- ['keystone:juju-info', 'landscape-client:container']
+- ['keystone:juju-info', 'logrotated:juju-info']
+- ['keystone:juju-info', 'nrpe:general-info']
+- ['keystone:juju-info', 'public-policy-routing:juju-info']
+- ['keystone:juju-info', 'telegraf:juju-info']
+- ['keystone:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['landscape-client:container', 'memcached:juju-info']
+- ['landscape-client:container', 'mysql-innodb-cluster:juju-info']
+- ['landscape-client:container', 'neutron-api:juju-info']
+- ['landscape-client:container', 'nova-cloud-controller:juju-info']
+- ['landscape-client:container', 'octavia:juju-info']
+- ['landscape-client:container', 'openstack-dashboard:juju-info']
+- ['landscape-client:container', 'openstack-service-checks:juju-info']
+- ['landscape-client:container', 'ovn-central:juju-info']
+- ['landscape-client:container', 'placement:juju-info']
+- ['landscape-client:container', 'prometheus-openstack-exporter:juju-info']
+- ['landscape-client:container', 'rabbitmq-server:juju-info']
+- ['landscape-client:container', 'vault:juju-info']
+- ['lldpd:juju-info', 'nova-compute:juju-info']
+- ['logrotated:juju-info', 'memcached:juju-info']
+- ['logrotated:juju-info', 'mysql-innodb-cluster:juju-info']
+- ['logrotated:juju-info', 'neutron-api:juju-info']
+- ['logrotated:juju-info', 'nova-cloud-controller:juju-info']
+- ['logrotated:juju-info', 'octavia:juju-info']
+- ['logrotated:juju-info', 'openstack-dashboard:juju-info']
+- ['logrotated:juju-info', 'openstack-service-checks:juju-info']
+- ['logrotated:juju-info', 'ovn-central:juju-info']
+- ['logrotated:juju-info', 'placement:juju-info']
+- ['logrotated:juju-info', 'prometheus-openstack-exporter:juju-info']
+- ['logrotated:juju-info', 'rabbitmq-server:juju-info']
+- ['logrotated:juju-info', 'vault:juju-info']
+- ['memcached:cache', 'nova-cloud-controller:memcache']
+- ['memcached:juju-info', 'nrpe:general-info']
+- ['memcached:juju-info', 'telegraf:juju-info']
+- ['memcached:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['mysql-innodb-cluster:db-router', 'neutron-api-mysql-router:db-router']
+- ['mysql-innodb-cluster:db-router', 'nova-cloud-controller-mysql-router:db-router']
+- ['mysql-innodb-cluster:db-router', 'octavia-mysql-router:db-router']
+- ['mysql-innodb-cluster:db-router', 'openstack-dashboard-mysql-router:db-router']
+- ['mysql-innodb-cluster:db-router', 'placement-mysql-router:db-router']
+- ['mysql-innodb-cluster:db-router', 'vault-mysql-router:db-router']
+- ['mysql-innodb-cluster:juju-info', 'nrpe:general-info']
+- ['mysql-innodb-cluster:juju-info', 'telegraf:juju-info']
+- ['nagios:monitors', 'nrpe:monitors']
+- ['neutron-api-mysql-router:shared-db', 'neutron-api:shared-db']
+- ['neutron-api-plugin-ovn:certificates', 'vault:certificates']
+- ['neutron-api-plugin-ovn:neutron-plugin', 'neutron-api:neutron-plugin-api-subordinate']
+- ['neutron-api-plugin-ovn:ovsdb-cms', 'ovn-central:ovsdb-cms']
+- ['neutron-api:amqp', 'rabbitmq-server:amqp']
+- ['neutron-api:certificates', 'vault:certificates']
+- ['neutron-api:juju-info', 'nrpe:general-info']
+- ['neutron-api:juju-info', 'public-policy-routing:juju-info']
+- ['neutron-api:juju-info', 'telegraf:juju-info']
+- ['neutron-api:neutron-api', 'nova-cloud-controller:neutron-api']
+- ['neutron-api:neutron-load-balancer', 'octavia:neutron-api']
+- ['neutron-api:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['nova-cloud-controller-mysql-router:shared-db', 'nova-cloud-controller:shared-db']
+- ['nova-cloud-controller:amqp', 'rabbitmq-server:amqp']
+- ['nova-cloud-controller:certificates', 'vault:certificates']
+- ['nova-cloud-controller:cloud-compute', 'nova-compute:cloud-compute']
+- ['nova-cloud-controller:juju-info', 'nrpe:general-info']
+- ['nova-cloud-controller:juju-info', 'public-policy-routing:juju-info']
+- ['nova-cloud-controller:juju-info', 'telegraf:juju-info']
+- ['nova-cloud-controller:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['nova-cloud-controller:placement', 'placement:placement']
+- ['nova-compute:amqp', 'rabbitmq-server:amqp']
+- ['nova-compute:juju-info', 'prometheus-libvirt-exporter:juju-info']
+- ['nova-compute:neutron-plugin', 'ovn-chassis:nova-compute']
+- ['nova-compute:nrpe-external-master', 'nrpe:nrpe-external-master']
+- ['nova-compute:secrets-storage', 'vault:secrets']
+- ['nrpe:general-info', 'octavia:juju-info']
+- ['nrpe:general-info', 'openstack-dashboard:juju-info']
+- ['nrpe:general-info', 'openstack-service-checks:juju-info']
+- ['nrpe:general-info', 'ovn-central:juju-info']
+- ['nrpe:general-info', 'placement:juju-info']
+- ['nrpe:general-info', 'prometheus-openstack-exporter:juju-info']
+- ['nrpe:general-info', 'rabbitmq-server:juju-info']
+- ['nrpe:general-info', 'vault:juju-info']
+- ['nrpe:nrpe-external-master', 'ntp:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'octavia:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'openstack-dashboard:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'openstack-service-checks:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'ovn-central:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'prometheus-libvirt-exporter:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'prometheus-openstack-exporter:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'rabbitmq-server:nrpe-external-master']
+- ['nrpe:nrpe-external-master', 'vault:nrpe-external-master']
+- ['ntp:juju-info', 'vault:juju-info']
+- ['octavia-dashboard:certificates', 'vault:certificates']
+- ['octavia-dashboard:dashboard', 'openstack-dashboard:dashboard-plugin']
+- ['octavia-diskimage-retrofit:certificates', 'vault:certificates']
+- ['octavia-mysql-router:shared-db', 'octavia:shared-db']
+- ['octavia-ovn-chassis:certificates', 'vault:certificates']
+- ['octavia-ovn-chassis:ovsdb-subordinate', 'octavia:ovsdb-subordinate']
+- ['octavia-ovn-chassis:ovsdb', 'ovn-central:ovsdb']
+- ['octavia:amqp', 'rabbitmq-server:amqp']
+- ['octavia:certificates', 'vault:certificates']
+- ['octavia:juju-info', 'public-policy-routing:juju-info']
+- ['octavia:juju-info', 'telegraf:juju-info']
+- ['octavia:ovsdb-cms', 'ovn-central:ovsdb-cms']
+- ['openstack-dashboard-mysql-router:shared-db', 'openstack-dashboard:shared-db']
+- ['openstack-dashboard:certificates', 'vault:certificates']
+- ['openstack-dashboard:juju-info', 'public-policy-routing:juju-info']
+- ['openstack-dashboard:juju-info', 'telegraf:juju-info']
+- ['openstack-service-checks:juju-info', 'telegraf:juju-info']
+- ['ovn-central:certificates', 'vault:certificates']
+- ['ovn-central:juju-info', 'telegraf:juju-info']
+- ['ovn-central:ovsdb', 'ovn-chassis:ovsdb']
+- ['ovn-chassis:certificates', 'vault:certificates']
+- ['placement-mysql-router:shared-db', 'placement:shared-db']
+- ['placement:amqp', 'rabbitmq-server:amqp']
+- ['placement:certificates', 'vault:certificates']
+- ['placement:juju-info', 'public-policy-routing:juju-info']
+- ['placement:juju-info', 'telegraf:juju-info']
+- ['prometheus-libvirt-exporter:scrape', 'prometheus:target']
+- ['prometheus-openstack-exporter:juju-info', 'telegraf:juju-info']
+- ['prometheus-openstack-exporter:prometheus-openstack-exporter-service', 'prometheus:target']
+- ['prometheus:target', 'telegraf:prometheus-client']
+- ['rabbitmq-server:juju-info', 'telegraf:juju-info']
+- ['telegraf:juju-info', 'vault:juju-info']
+- ['vault-mysql-router:shared-db', 'vault:shared-db']
diff --git a/tests/conftest.py b/tests/unit/conftest.py
similarity index 100%
rename from tests/conftest.py
rename to tests/unit/conftest.py
diff --git a/tests/requirements.txt b/tests/unit/requirements.txt
similarity index 100%
rename from tests/requirements.txt
rename to tests/unit/requirements.txt
diff --git a/tests/test_check_spaces.py b/tests/unit/test_check_spaces.py
similarity index 100%
rename from tests/test_check_spaces.py
rename to tests/unit/test_check_spaces.py
diff --git a/tests/test_cli.py b/tests/unit/test_cli.py
similarity index 100%
rename from tests/test_cli.py
rename to tests/unit/test_cli.py
diff --git a/tests/test_cloud.py b/tests/unit/test_cloud.py
similarity index 100%
rename from tests/test_cloud.py
rename to tests/unit/test_cloud.py
diff --git a/tests/test_jujulint.py b/tests/unit/test_jujulint.py
similarity index 100%
rename from tests/test_jujulint.py
rename to tests/unit/test_jujulint.py
diff --git a/tests/test_k8s.py b/tests/unit/test_k8s.py
similarity index 100%
rename from tests/test_k8s.py
rename to tests/unit/test_k8s.py
diff --git a/tests/test_logging.py b/tests/unit/test_logging.py
similarity index 100%
rename from tests/test_logging.py
rename to tests/unit/test_logging.py
diff --git a/tests/test_openstack.py b/tests/unit/test_openstack.py
similarity index 100%
rename from tests/test_openstack.py
rename to tests/unit/test_openstack.py
diff --git a/tox.ini b/tox.ini
index e37275c..31ae64d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -18,7 +18,7 @@ skip_missing_interpreters = True
 [testenv]
 basepython = python3.8
 deps =
-    -r{toxinidir}/tests/requirements.txt
+    -r{toxinidir}/tests/unit/requirements.txt
     -r{toxinidir}/requirements.txt
 
 [testenv:unit]
@@ -30,11 +30,43 @@ commands =
     --last-failed-no-failures all \
     --cov-fail-under=100 \
     --cov-report=term-missing \
-    --cov-report=annotate:tests/report/coverage-annotated \
-    --cov-report=html:tests/report/coverage-html \
-    --html=tests/report/index.html \
-    --junitxml=tests/report/junit.xml
-setenv = PYTHONPATH={toxinidir}/lib
+    --cov-report=annotate:tests/unit/report/coverage-annotated \
+    --cov-report=html:tests/unit/report/coverage-html \
+    --html=tests/unit/report/index.html \
+    --junitxml=tests/unit/report/junit.xml \
+    --ignore={toxinidir}/tests/functional
+setenv = PYTHONPATH={toxinidir}
+
+[testenv:func]
+passenv =
+    JUJULINT_TEST_*
+deps =
+    {[testenv]deps}
+    -r{toxinidir}/tests/functional/requirements.txt
+commands =
+    pytest -v \
+    --log-cli-level=WARNING \
+    --ignore={toxinidir}/tests/unit \
+    {posargs}
+
+[testenv:func-smoke]
+deps =
+    {[testenv]deps}
+    -r{toxinidir}/tests/functional/requirements.txt
+commands =
+    pytest -v \
+    --log-cli-level=WARNING \
+    --ignore={toxinidir}/tests/unit \
+    -m smoke
+
+[testenv:func-dev]
+deps =
+    {[testenv]deps}
+    -r{toxinidir}/tests/functional/requirements.txt
+commands =
+    pytest -v \
+    --log-cli-level=WARNING \
+    --ignore={toxinidir}/tests/unit
 
 [testenv:lint]
 commands =
@@ -48,8 +80,6 @@ commands =
     black .
     isort .
 
-[testenv:func]
-#TODO(gabrielcocenza) add func tests
 
 [pytest]
 filterwarnings =