Merge ~gabrielcocenza/juju-lint:bug/1971645 into juju-lint:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Eric Chen
Approved revision: 61428a56ee9b4164cd8d72d0396030b353d9a85d
Merged at revision: ba87a4f8dee95f906769f1fcfff25341c23b0fa9
Proposed branch: ~gabrielcocenza/juju-lint:bug/1971645
Merge into: juju-lint:master
Diff against target: 19 lines (+7/-0)
1 file modified
contrib/includes/base.yaml (+7/-0)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Erhan Sunar (community) Approve
Mert Kirpici (community) Approve
Review via email: mp+431752@code.launchpad.net

Commit message

alert on filebeat being directly related to elasticsearch

Closes-Bug: #1971645

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tianqi Xiao (txiao) wrote :

Not a reviewer, but I would like to leave a nit-picking comment as I'm passing by

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

small, directed change. thanks Gabriel.

review: Approve
Revision history for this message
Erhan Sunar (esunar) wrote :

LGTM

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision ba87a4f8dee95f906769f1fcfff25341c23b0fa9

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/contrib/includes/base.yaml b/contrib/includes/base.yaml
index 8e0a2ce..e8016f7 100644
--- a/contrib/includes/base.yaml
+++ b/contrib/includes/base.yaml
@@ -65,3 +65,10 @@ relations base check: &relations-base-check
6565
66 - charm: ubuntu-advantage66 - charm: ubuntu-advantage
67 ubiquitous: true67 ubiquitous: true
68
69# relating filebeat to elasticsearch:client causes unnecessary extra logging
70# See LP#1971645
71 - charm: elasticsearch
72 not-exist: [
73 ["elasticsearch:client", "filebeat:elasticsearch"]
74 ]
diff --git a/tests/unit/test_check_spaces.py b/tests/unit/test_spaces.py
68similarity index 100%75similarity index 100%
69rename from tests/unit/test_check_spaces.py76rename from tests/unit/test_check_spaces.py
70rename to tests/unit/test_spaces.py77rename to tests/unit/test_spaces.py

Subscribers

People subscribed via source and target branches