Juju Lint

Merge ~gabrielcocenza/juju-lint:bug/1971645 into juju-lint:master

  1. Git
  2. lp:~gabrielcocenza/juju-lint
  3. bug/1971645
  4. Merge into master
Proposed by Gabriel Cocenza
Status: Merged
Approved by: Eric Chen
Approved revision: 61428a56ee9b4164cd8d72d0396030b353d9a85d
Merged at revision: ba87a4f8dee95f906769f1fcfff25341c23b0fa9
Proposed branch: ~gabrielcocenza/juju-lint:bug/1971645
Merge into: juju-lint:master
Diff against target: 19 lines (+7/-0)
1 file modified
contrib/includes/base.yaml (+7/-0)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-bootstack continuous-integration Approve
Erhan Sunar (community) Approve
Mert Kirpici (community) Approve
Review via email: mp+431752@code.launchpad.net

Commit message

alert on filebeat being directly related to elasticsearch

Closes-Bug: #1971645

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:f4707aaff688ae0e82699d84bcea20adc172e3da
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/14/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1113/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1530/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/14//rebuild

review: Approve (continuous-integration)
Revision history for this message
Tianqi Xiao (txiao) wrote :

Not a reviewer, but I would like to leave a nit-picking comment as I'm passing by

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:9db9a98e0c02c1f9171e1eef20cb5d1a95ae6a22
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/15/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1114/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1531/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/15//rebuild

review: Approve (continuous-integration)
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

small, directed change. thanks Gabriel.

review: Approve
Revision history for this message
Erhan Sunar (esunar) wrote :

LGTM

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:61428a56ee9b4164cd8d72d0396030b353d9a85d
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/16/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1122/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1541/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-juju-lint-ci/16//rebuild

review: Approve (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision ba87a4f8dee95f906769f1fcfff25341c23b0fa9

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/includes/base.yaml b/contrib/includes/base.yaml
2index 8e0a2ce..e8016f7 100644
3--- a/contrib/includes/base.yaml
4+++ b/contrib/includes/base.yaml
5@@ -65,3 +65,10 @@ relations base check: &relations-base-check
6
7 - charm: ubuntu-advantage
8 ubiquitous: true
9+
10+# relating filebeat to elasticsearch:client causes unnecessary extra logging
11+# See LP#1971645
12+ - charm: elasticsearch
13+ not-exist: [
14+ ["elasticsearch:client", "filebeat:elasticsearch"]
15+ ]
16diff --git a/tests/unit/test_check_spaces.py b/tests/unit/test_spaces.py
17similarity index 100%
18rename from tests/unit/test_check_spaces.py
19rename to tests/unit/test_spaces.py

Subscribers

People subscribed via source and target branches