Code review comment for ~gabrielcocenza/juju-lint:bug/1939748

Revision history for this message
Gabriel Cocenza (gabrielcocenza) wrote :

Thanks for your review Martin.

I do agree with you that inside wasn't the best naming for that and the regex can be better explored for other use cases that might be necessary to the future.

I just changed the name from "match" as you proposed to "search" because the operator `eq` uses `re.match` in the `helper_operator_eq_check` and can be a little confusing for someone that is looking the code. The new `search` operator uses `re.search` so I think the naming might be better at this situation.

« Back to merge proposal