Code review comment for ~gabrielcocenza/juju-lint:bug/1939748

Revision history for this message
Martin Kalcok (martin-kalcok) wrote :

I'm not sure I'm completely convinced with the `inside` operator. I find the naming itself bit confusing. Current syntax

config_name:
  inside: "some_string"

sounds like the config value should be "substring" of the value that's in the `inside` directive. Alternative name could be "includes" ?

Secondly, If we want to add more flexible option than those that currently exist, maybe we should go for a operator that would match regexp. Example:

config_name:
  match: "regexp"

this would imo add more flexibility than `inside`.

I would also maybe check with the bootstack team about how often they set specific thresholds for individual queues. Because if most of the deployments just setup thresholds with wildcards, we can fix this by simply using.

queue_thresholds:
  eq: "[['\*', '\*', 25000, 27500]]"

That way we could exclude the discussion about the new operator to new ticket/issue.

review: Needs Information

« Back to merge proposal