Merge ~gabrielcocenza/juju-lint:bug/1967325 into juju-lint:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Alvaro Uria
Approved revision: 4aaf5103e38fc12d56d2793fce53aa434df4dcd0
Merged at revision: 6e6ba3cb4283fdf5477f70ec3bb0631017787838
Proposed branch: ~gabrielcocenza/juju-lint:bug/1967325
Merge into: juju-lint:master
Diff against target: 74 lines (+7/-6)
4 files modified
contrib/canonical-rules.yaml (+2/-2)
contrib/includes/kubernetes.yaml (+2/-2)
contrib/kubernetes.yaml (+1/-0)
tests/test_jujulint.py (+2/-2)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Review via email: mp+422033@code.launchpad.net

Commit message

fix k8s rules

- add additional import for k8s dependencies for
  operations-openstack-mandatory-series
- changed from kubernetes-master to kubernetes-control-plane

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Alvaro Uria (aluria) wrote :

+1 from me.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6e6ba3cb4283fdf5477f70ec3bb0631017787838

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
index 9056390..8abd854 100644
--- a/contrib/canonical-rules.yaml
+++ b/contrib/canonical-rules.yaml
@@ -1,7 +1,7 @@
1---1---
2# legacy rules file, there are also more specific configurations available2# legacy rules file, there are also more specific configurations available
3kubernetes config:3kubernetes config:
4 kubernetes-master:4 kubernetes-control-plane:
5 authorization-mode:5 authorization-mode:
6 eq: "RBAC,Node"6 eq: "RBAC,Node"
7 canal:7 canal:
@@ -97,7 +97,7 @@ subordinates:
97kubernetes mandatory: &kubernetes-mandatory-charms97kubernetes mandatory: &kubernetes-mandatory-charms
98 - containerd98 - containerd
99 - kubeapi-load-balancer99 - kubeapi-load-balancer
100 - kubernetes-master100 - kubernetes-control-plane
101 - kubernetes-worker101 - kubernetes-worker
102102
103kubernetes optional charms: &kubernetes-optional-charms103kubernetes optional charms: &kubernetes-optional-charms
diff --git a/contrib/includes/kubernetes.yaml b/contrib/includes/kubernetes.yaml
index 02d5fa0..2ade8ed 100644
--- a/contrib/includes/kubernetes.yaml
+++ b/contrib/includes/kubernetes.yaml
@@ -1,5 +1,5 @@
1kubernetes config:1kubernetes config:
2 kubernetes-master:2 kubernetes-control-plane:
3 authorization-mode:3 authorization-mode:
4 eq: "RBAC,Node"4 eq: "RBAC,Node"
5 canal:5 canal:
@@ -9,7 +9,7 @@ kubernetes config:
9kubernetes mandatory: &kubernetes-mandatory-charms9kubernetes mandatory: &kubernetes-mandatory-charms
10 - containerd10 - containerd
11 - kubeapi-load-balancer11 - kubeapi-load-balancer
12 - kubernetes-master12 - kubernetes-control-plane
13 - kubernetes-worker13 - kubernetes-worker
1414
15kubernetes optional charms: &kubernetes-optional-charms15kubernetes optional charms: &kubernetes-optional-charms
diff --git a/contrib/kubernetes.yaml b/contrib/kubernetes.yaml
index c7460b1..27eeba6 100644
--- a/contrib/kubernetes.yaml
+++ b/contrib/kubernetes.yaml
@@ -1,5 +1,6 @@
1---1---
2!include includes/base.yaml2!include includes/base.yaml
3!include includes/operations/focal.yaml
3!include includes/operations.yaml4!include includes/operations.yaml
4!include includes/kubernetes.yaml5!include includes/kubernetes.yaml
5!include includes/saas.yaml6!include includes/saas.yaml
diff --git a/tests/test_jujulint.py b/tests/test_jujulint.py
index 1ec6cdf..c4c51f3 100644
--- a/tests/test_jujulint.py
+++ b/tests/test_jujulint.py
@@ -437,14 +437,14 @@ applications:
437 def test_kubernetes_charm_missing(self, linter, juju_status):437 def test_kubernetes_charm_missing(self, linter, juju_status):
438 """Test that missing kubernetes mandatory charms are detected."""438 """Test that missing kubernetes mandatory charms are detected."""
439 linter.cloud_type = "kubernetes"439 linter.cloud_type = "kubernetes"
440 linter.lint_rules["kubernetes mandatory"] = ["kubernetes-master"]440 linter.lint_rules["kubernetes mandatory"] = ["kubernetes-control-plane"]
441 linter.lint_rules["operations kubernetes mandatory"] = []441 linter.lint_rules["operations kubernetes mandatory"] = []
442 linter.do_lint(juju_status)442 linter.do_lint(juju_status)
443443
444 errors = linter.output_collector["errors"]444 errors = linter.output_collector["errors"]
445 assert len(errors) == 1445 assert len(errors) == 1
446 assert errors[0]["id"] == "kubernetes-charm-missing"446 assert errors[0]["id"] == "kubernetes-charm-missing"
447 assert errors[0]["charm"] == "kubernetes-master"447 assert errors[0]["charm"] == "kubernetes-control-plane"
448448
449 def test_kubernetes_ops_charm_missing(self, linter, juju_status):449 def test_kubernetes_ops_charm_missing(self, linter, juju_status):
450 """Test that missing kubernetes mandatory charms are detected."""450 """Test that missing kubernetes mandatory charms are detected."""

Subscribers

People subscribed via source and target branches