Merge ~gabrielcocenza/juju-lint:bug/1967325 into juju-lint:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Alvaro Uria
Approved revision: 4aaf5103e38fc12d56d2793fce53aa434df4dcd0
Merged at revision: 6e6ba3cb4283fdf5477f70ec3bb0631017787838
Proposed branch: ~gabrielcocenza/juju-lint:bug/1967325
Merge into: juju-lint:master
Diff against target: 74 lines (+7/-6)
4 files modified
contrib/canonical-rules.yaml (+2/-2)
contrib/includes/kubernetes.yaml (+2/-2)
contrib/kubernetes.yaml (+1/-0)
tests/test_jujulint.py (+2/-2)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Review via email: mp+422033@code.launchpad.net

Commit message

fix k8s rules

- add additional import for k8s dependencies for
  operations-openstack-mandatory-series
- changed from kubernetes-master to kubernetes-control-plane

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Alvaro Uria (aluria) wrote :

+1 from me.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6e6ba3cb4283fdf5477f70ec3bb0631017787838

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
2index 9056390..8abd854 100644
3--- a/contrib/canonical-rules.yaml
4+++ b/contrib/canonical-rules.yaml
5@@ -1,7 +1,7 @@
6 ---
7 # legacy rules file, there are also more specific configurations available
8 kubernetes config:
9- kubernetes-master:
10+ kubernetes-control-plane:
11 authorization-mode:
12 eq: "RBAC,Node"
13 canal:
14@@ -97,7 +97,7 @@ subordinates:
15 kubernetes mandatory: &kubernetes-mandatory-charms
16 - containerd
17 - kubeapi-load-balancer
18- - kubernetes-master
19+ - kubernetes-control-plane
20 - kubernetes-worker
21
22 kubernetes optional charms: &kubernetes-optional-charms
23diff --git a/contrib/includes/kubernetes.yaml b/contrib/includes/kubernetes.yaml
24index 02d5fa0..2ade8ed 100644
25--- a/contrib/includes/kubernetes.yaml
26+++ b/contrib/includes/kubernetes.yaml
27@@ -1,5 +1,5 @@
28 kubernetes config:
29- kubernetes-master:
30+ kubernetes-control-plane:
31 authorization-mode:
32 eq: "RBAC,Node"
33 canal:
34@@ -9,7 +9,7 @@ kubernetes config:
35 kubernetes mandatory: &kubernetes-mandatory-charms
36 - containerd
37 - kubeapi-load-balancer
38- - kubernetes-master
39+ - kubernetes-control-plane
40 - kubernetes-worker
41
42 kubernetes optional charms: &kubernetes-optional-charms
43diff --git a/contrib/kubernetes.yaml b/contrib/kubernetes.yaml
44index c7460b1..27eeba6 100644
45--- a/contrib/kubernetes.yaml
46+++ b/contrib/kubernetes.yaml
47@@ -1,5 +1,6 @@
48 ---
49 !include includes/base.yaml
50+!include includes/operations/focal.yaml
51 !include includes/operations.yaml
52 !include includes/kubernetes.yaml
53 !include includes/saas.yaml
54diff --git a/tests/test_jujulint.py b/tests/test_jujulint.py
55index 1ec6cdf..c4c51f3 100644
56--- a/tests/test_jujulint.py
57+++ b/tests/test_jujulint.py
58@@ -437,14 +437,14 @@ applications:
59 def test_kubernetes_charm_missing(self, linter, juju_status):
60 """Test that missing kubernetes mandatory charms are detected."""
61 linter.cloud_type = "kubernetes"
62- linter.lint_rules["kubernetes mandatory"] = ["kubernetes-master"]
63+ linter.lint_rules["kubernetes mandatory"] = ["kubernetes-control-plane"]
64 linter.lint_rules["operations kubernetes mandatory"] = []
65 linter.do_lint(juju_status)
66
67 errors = linter.output_collector["errors"]
68 assert len(errors) == 1
69 assert errors[0]["id"] == "kubernetes-charm-missing"
70- assert errors[0]["charm"] == "kubernetes-master"
71+ assert errors[0]["charm"] == "kubernetes-control-plane"
72
73 def test_kubernetes_ops_charm_missing(self, linter, juju_status):
74 """Test that missing kubernetes mandatory charms are detected."""

Subscribers

People subscribed via source and target branches