Code review comment for lp:~g-gorman/fluidity/fluidity-petsc-3.3

Revision history for this message
Stephan Kramer (s-kramer) wrote :

Just to recap for those not present at the dev-meeting: we decided to go ahead with this merge as is, so that people depending on petsc 3.3 don't have to wait. A cleanup of the petsc-version specific hackery is still very much appreciated and shall be done in someone's copious free time. Also we discussed possibly dropping support for petsc 3.1 and petsc 3.2, and roll our own petsc 3.3 packages on a ppa as long as Ubuntu's catching up. I'll try to friendly nudge the Debian package maintainer and ask for an upgrade of their package (Debian unstable is on 3.2), so we could simply back(trans?)-port it to Ubuntu.

James: would you mind committing that fix to the unit-test with another ugly "#if PETSC_VERSION_MINOR>=2"...#else ... to make it work with 3.1. Or commit what you have and I'll add the hacks? This stuff will go away as soon as we drop support for 3.1

« Back to merge proposal