Merge lp:~frankban/juju-quickstart/initial-vivid-support into lp:juju-quickstart
Status: | Merged |
---|---|
Merged at revision: | 114 |
Proposed branch: | lp:~frankban/juju-quickstart/initial-vivid-support |
Merge into: | lp:juju-quickstart |
Diff against target: |
202 lines (+36/-28) 6 files modified
quickstart/__init__.py (+1/-1) quickstart/app.py (+3/-3) quickstart/netutils.py (+3/-3) quickstart/settings.py (+9/-7) quickstart/tests/test_app.py (+9/-9) quickstart/tests/test_netutils.py (+11/-5) |
To merge this branch: | bzr merge lp:~frankban/juju-quickstart/initial-vivid-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+246199@code.launchpad.net |
Description of the change
Use charm store API to retrieve GUI revision.
This branch includes the following small fixes
in preparation for the 1.6 release:
- bump version up to 1.6.0;
- use the charm store API to retrieve the URL
of the last revision of the juju-gui charm;
- add initial support for vivid: the new series can now
be selected as default bootstrap node series when
creating/editing environments.
Tests: `make check`.
QA:
- just run `.venv/bin/python juju-quickstart` as
usual, locally and on a ec2 environment
(it would be nice if both precise and trusty
are used as default series in this QA); check
that vivid can be added as a default-series
in the environment edit view; check that
the last Juju GUI revision is correctly retrieved.
Reviewers: mp+246199_ code.launchpad. net,
Message:
Please take a look.
Description:
Use charm store API to retrieve GUI revision.
This branch includes the following small fixes
in preparation for the 1.6 release:
- bump version up to 1.6.0;
- use the charm store API to retrieve the URL
of the last revision of the juju-gui charm;
- add initial support for vivid: the new series can now
be selected as default bootstrap node series when
creating/editing environments.
Tests: `make check`.
QA:
- just run `.venv/bin/python juju-quickstart` as
usual, locally and on a ec2 environment
(it would be nice if both precise and trusty
are used as default series in this QA); check
that vivid can be added as a default-series
in the environment edit view; check that
the last Juju GUI revision is correctly retrieved.
https:/ /code.launchpad .net/~frankban/ juju-quickstart /initial- vivid-support/ +merge/ 246199
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/197740043/
Affected files (+38, -28 lines): __init_ _.py netutils. py settings. py tests/test_ app.py tests/test_ netutils. py
A [revision details]
M quickstart/
M quickstart/app.py
M quickstart/
M quickstart/
M quickstart/
M quickstart/
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>
Index: quickstart/ __init_ _.py __init_ _.py' __init_ _.py 2014-11-10 11:27:04 +0000 __init_ _.py 2015-01-12 14:30:44 +0000
=== modified file 'quickstart/
--- quickstart/
+++ quickstart/
@@ -45,7 +45,7 @@
Once Juju has been installed, the command can also be run as a juju plugin,
without the hyphen ("juju quickstart").
"""
-VERSION = (1, 5, 0)
+VERSION = (1, 6, 0)
def get_version():
Index: quickstart/app.py
=== modified file 'quickstart/app.py'
--- quickstart/app.py 2014-12-16 14:12:44 +0000
+++ quickstart/app.py 2015-01-12 15:00:52 +0000
@@ -386,8 +386,8 @@
unit.
If the charm URL is not provided, and the service is not already
deployed,
- the function tries to retrieve it from the charmworld API. In this
case a
- default charm URL is used if charmworld is not available.
+ the function tries to retrieve it from the charm store API. In this
case a
+ default charm URL is used if the charm store service is not available.
Return a tuple including the following values:
series = settings. JUJU_GUI_ SUPPORTED_ SERIES[ -1]
charm_ url = netutils. get_charm_ url(series)
except (IOError, ValueError) as err:
- charm_url: the charm URL that will be used to deploy the service;
@@ -418,7 +418,7 @@
else:
try:
- # Try to get the charm URL from charmworld.
+ # Try to get the charm URL from the charm store API.
# Fall back to the default URL for the current series.
Index:...