lp:~frankban/juju-quickstart/initial-vivid-support

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 114

Juju GUI Hackers: Pending requested 2015-01-12

Diff: 202 lines (+36/-28)

6 files modified

quickstart/__init__.py (+1/-1)
quickstart/app.py (+3/-3)
quickstart/netutils.py (+3/-3)
quickstart/settings.py (+9/-7)
quickstart/tests/test_app.py (+9/-9)
quickstart/tests/test_netutils.py (+11/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

121. By Francesco Banconi on 2015-01-12

Merge trunk.

120. By Francesco Banconi on 2015-01-12

Merge the remove-jenv branch.

119. By Francesco Banconi on 2015-01-12

Update to the correct charm store API.

118. By Francesco Banconi on 2015-01-12

Retrieve the last revision of the Juju GUI charm from the charm store.

117. By Francesco Banconi on 2015-01-12

Update juju-gui default revision for each series.

116. By Francesco Banconi on 2015-01-12

Bump version up to 1.6.0.

115. By Francesco Banconi on 2015-01-12

Add vivid as an option for bootstrap node series.

114. By Francesco Banconi on 2015-01-12

Complete the test suite for jenv removal functionality.

113. By Francesco Banconi on 2015-01-12

Functionality implemented, just one missing test.

112. By Francesco Banconi on 2015-01-12

Reorganize view code.

Replace most of the view closures with external
private functions.
This has several good side effects in my opinion:
- view functions are shorter;
- we know which objects are used for each callback
  function, because we need to explicitly pass them
  as arguments;
- external functions can be reused by multiple views
  if required (and we have the _use example here);
- if an external callback become less straightforward,
  it is now possible to directly unit test it.

Tests: `make check`.

QA:
If unit tests pass we have some confidence that
the interactive session is not broken.
However, some time spent on it would be great,
creating/editing/destroying environments, setting
them as default, canceling the changes, starting
one of them, etc...
Thanks a lot.

R=matthew.scott, bac
CC=
https://codereview.appspot.com/194080043