Code review comment for lp:~frankban/juju-quickstart/improve-input-handling

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+199640_code.launchpad.net,

Message:
Please take a look.

Description:
Improve views input handling.

Add a new set_return_value_on_exit API that
views can call to set the value encapsulated
in the AppExit exception raised when the user
quits the application with ^X.

Tests: `make check`

QA: start the demo app
(`make` and `./cli-app-demo.py).
Try exiting with ^X: you should see the
"no environment selected" message.
Restart and exit selecting an environment:
you should see a message indicating that
environment has been selected.
Restart and change the default environment,
then exit: you should see the new env_db
printed and the new default environment.

https://code.launchpad.net/~frankban/juju-quickstart/improve-input-handling/+merge/199640

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/43600047/

Affected files (+110, -41 lines):
   A [revision details]
   M cli-app-demo.py
   M quickstart/cli/base.py
   M quickstart/cli/views.py
   A quickstart/tests/cli/helpers.py
   M quickstart/tests/cli/test_base.py
   M quickstart/tests/cli/test_views.py

« Back to merge proposal