lp:~frankban/juju-quickstart/improve-input-handling

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 39

Juju GUI Hackers: Pending requested 2013-12-19

Diff: 337 lines (+110/-41)

6 files modified

cli-app-demo.py (+3/-0)
quickstart/cli/base.py (+17/-2)
quickstart/cli/views.py (+25/-17)
quickstart/tests/cli/helpers.py (+31/-0)
quickstart/tests/cli/test_base.py (+20/-1)
quickstart/tests/cli/test_views.py (+14/-21)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

44. By Francesco Banconi on 2013-12-19

Add missing import unicode_literals.

43. By Francesco Banconi on 2013-12-19

Fix typos.

42. By Francesco Banconi on 2013-12-19

Add all the tests.

41. By Francesco Banconi on 2013-12-19

Code completed.

40. By Francesco Banconi on 2013-12-19

Improve the demo script.

39. By Francesco Banconi on 2013-12-19

Add the new app.set_return_value_on_exit API.

38. By Francesco Banconi on 2013-12-19

Environment list/selection view.

This branch implements the environment
selection Urwid view. It is possible to
start it running `make` and then
`./cli-app-demo.py`. This is still not
integrated in quickstart, but the demo
file demonstrates how to show the view
passing the required data structures
already implemented in the
quickstart.models.envs module.

To test the branch, run `make check`.

To QA the new functionality, run the
demo application as described above,
and play with the interface: any UX
suggestion is welcome, and will be part
of a card we already have
("envs management: ux improvements").

Other changes:

The Urwid application is no longer an
ObjectDict (removed from the code).
I decided to use a Python namedtuple
which seemed to me a better choice,
considering that views are not supposed
to modify the app data structure.
This way we have both immutability and
attribute access to the object.

Implemented a TimeoutText wrapper used to
wrap the message notification widget.
This wayt he timer is restarted when a
subsequent message is set and the previous
has not yet been removed.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/43860044

37. By Madison Scott-Clary on 2013-12-19

Watch for SSH key creation

Allow the user to create SSH keys in another term/window, watch for creation and continue when available.

To test: make check
To QA:
1. Move ~/.ssh to a back up
2. Run quickstart - select w when prompted to watch
3. Create ssh keys as instructed in another term/window
4. Quickstart should continue
5. Move ~/.ssh back; other options should work as expected.

R=gary.poster, frankban, rharding
CC=
https://codereview.appspot.com/39610049

36. By Francesco Banconi on 2013-12-17

Improve unexpected fields handling.

Implement the UnexpectedField type. This is used
to handle unexpected key/value pairs found in
the environments.yaml file. The user will be able
to get rid of those fields just deleting their
values from in the interactive session.

Tests: `make check`.
No QA.

R=matthew.scott
CC=
https://codereview.appspot.com/43380043

35. By Francesco Banconi on 2013-12-17

Quickstart base structure for views.

This branch implements a way to start
Urwid interactive sessions in quickstart.
This infrastructure will be used in
future branches to implement the
quickstart environment management system.

My apologies for the long diff, but you
can safely ignore all the file headers,
and the code includes long module
docstrings which can help reviewing the
branch.

Tests: `make check`.

QA:
run `make` and then `./cli-app-demo.py`:
this will start a demo application using
the views infrastructure.

Thank you!

R=gary.poster, bac
CC=
https://codereview.appspot.com/42600044