LGTM. Will QA now.
https://codereview.appspot.com/169380043/diff/1/HACKING.rst File HACKING.rst (right):
https://codereview.appspot.com/169380043/diff/1/HACKING.rst#newcode78 HACKING.rst:78: A very nice introduction to the code layout. Thanks for including it.
https://codereview.appspot.com/169380043/diff/1/quickstart/models/jenv.py File quickstart/models/jenv.py (right):
https://codereview.appspot.com/169380043/diff/1/quickstart/models/jenv.py#newcode39 quickstart/models/jenv.py:39: def get_value(env_name, *args): Why did you chose to use *args here instead of a tuple of key names?
https://codereview.appspot.com/169380043/diff/1/quickstart/tests/helpers.py File quickstart/tests/helpers.py (right):
https://codereview.appspot.com/169380043/diff/1/quickstart/tests/helpers.py#newcode156 quickstart/tests/helpers.py:156: In the contentx manager block, the JUJU_HOME is set to the ancestor typo: contextx
https://codereview.appspot.com/169380043/
« Back to merge proposal
LGTM. Will QA now.
https:/ /codereview. appspot. com/169380043/ diff/1/ HACKING. rst
File HACKING.rst (right):
https:/ /codereview. appspot. com/169380043/ diff/1/ HACKING. rst#newcode78
HACKING.rst:78:
A very nice introduction to the code layout. Thanks for including it.
https:/ /codereview. appspot. com/169380043/ diff/1/ quickstart/ models/ jenv.py models/ jenv.py (right):
File quickstart/
https:/ /codereview. appspot. com/169380043/ diff/1/ quickstart/ models/ jenv.py# newcode39 models/ jenv.py: 39: def get_value(env_name, *args):
quickstart/
Why did you chose to use *args here instead of a tuple of key names?
https:/ /codereview. appspot. com/169380043/ diff/1/ quickstart/ tests/helpers. py tests/helpers. py (right):
File quickstart/
https:/ /codereview. appspot. com/169380043/ diff/1/ quickstart/ tests/helpers. py#newcode156 tests/helpers. py:156: In the contentx manager block, the
quickstart/
JUJU_HOME is set to the ancestor
typo: contextx
https:/ /codereview. appspot. com/169380043/