lp:~frankban/juju-quickstart/code-reorg

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 104

Juju GUI Hackers: Pending requested 2014-11-11

Diff: 849 lines (+370/-222)

12 files modified

HACKING.rst (+55/-1)
quickstart/app.py (+10/-21)
quickstart/manage.py (+3/-15)
quickstart/models/envs.py (+1/-30)
quickstart/models/jenv.py (+71/-0)
quickstart/serializers.py (+20/-0)
quickstart/tests/helpers.py (+36/-0)
quickstart/tests/models/test_envs.py (+0/-76)
quickstart/tests/models/test_jenv.py (+110/-0)
quickstart/tests/test_app.py (+16/-18)
quickstart/tests/test_manage.py (+7/-61)
quickstart/tests/test_serializers.py (+41/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

106. By Francesco Banconi on 2014-11-11

Add project structure docs.

105. By Francesco Banconi on 2014-11-11

Done.

104. By Francesco Banconi on 2014-11-11

Proto.

103. By Francesco Banconi on 2014-11-10

Unit address from the machines watcher only

Only use the mega-watcher for machines to retrieve
the Juju GUI unit address.
This change has several consequences:
- it allows us to apply some logic on how the
  right address is chosen. For instance, now
  we try to resolve public hostnames before
  proceeding, and this should fix the cases
  where a cloud dns is not configured on the
  machine running quickstart. This is the case
  of many maas environments;
- it simplifies parsing the mega-watcher changes;
- more importantly, it breaks compatibility
  with very old versions of juju (<1.18), in which
  the mega-watcher for machines did not include
  machine addresses.

For this reason, quickstart now explicitly
drops support for juju < 1.18.1
(1.18.1 is the version on trusty universe).

This also allows for removing some version
checks in the code, including sudo handling when
calling bootstrap on local envs, several special
cases on the watcher side, and other oddities.

For the reasons above, I bumped the quickstart
version up to 1.5.0.

PS: my apologies for the long diff, hope the code
is still easy to follow. Sorry.

Tests: `make check`

QA:
run quickstart as usual, on local and cloud envs,
check it works properly when run again, etc.
this branch has been already successfully QAed in
a maas environment by Adam (Landscape team).

R=bac, rharding
CC=
https://codereview.appspot.com/174790043

102. By Francesco Banconi on 2014-11-10

Do not hide errors on interactive session.

R=jay.wren, bac
CC=
https://codereview.appspot.com/166420044

101. By Francesco Banconi on 2014-10-10

Support automatic detection of a logged in MAAS.

Automatically detect a logged in MAAS API, so that
it is possible to use the stored credentials to
create and bootstrap a MAAS environment without
user intervention.

QA:
- ssh to the GUI MAAS;
- destroy the existing environment;
- remove the ~/.juju directory;
- use the MAAS UI (http://maas.jujugui.org/MAAS/nodes/)
  to release the nodes if they are not in a ready state;
- this branch is already checked out in ~/juju-quickstart/sandbox/;
- start quickstart from there:
  cd ~/juju-quickstart/sandbox/ && .venv/bin/python juju-quickstart
- quickstart should show the option to automatically create and
  bootstrap the MAAS environment;
- select the option and wait for the envirnment to be ready:
  this can fail due to juju/maas interaction problems we currently
  have, retrying the process should eventually succeed.

Done, thank you!

R=bac, jay.wren
CC=
https://codereview.appspot.com/157830043

100. By Francesco Banconi on 2014-10-01

Add MAAS support to quickstart.

Also bump version up and update tge default
Juju GUI charm URLs used when charmworld cannot
be contacted.

Tests: `make check`.

QA: already done on a live MAAS instance.
However, it is possible to just try to create
a MAAS environment YAML via the interactive
session.

R=bac, rharding
CC=
https://codereview.appspot.com/151200043

99. By Francesco Banconi on 2014-09-11

Bump version up for 1.4.3 release.

R=
CC=
https://codereview.appspot.com/135700043

98. By Francesco Banconi on 2014-09-08

Updated quickstart dependencies for utopic.

Quickstart now uses the dependency versions we
expect to be available in utopic.

Update the code parts in which quickstart interacts
with the juju client and the websocket Python
libraries: ensure we only log the textual WebSocket
messages we are interested in.

Also remove the deprecated --use-mirrors pip option.

Tests: `make check`

QA:
Use quickstart as usual to bootstrap local, ec2 and HP
environments: `.venv/bin/python juju-quickstart -e ...`

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/139350043

97. By Francesco Banconi on 2014-09-01

Updates for utopic.

Update docs and settings: inlcude
newly supported platform utopic and
remove support for saucy.

R=matthew.scott
CC=
https://codereview.appspot.com/139010043