Code review comment for lp:~frankban/juju-quickstart/code-reorg

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+241416_code.launchpad.net,

Message:
Please take a look.

Description:
Code reorganization + docs.

Reorganize the jenv related code in preparation of the
bootstrap strategy change.

Separate jenv handling from the environments.yaml file
management in models.

As a consequence of only supporting juju >= 1.18 we
can now safely always retrieve the admin-secret from
the jenv file.

Also updated the HACKING docs to include a brief
description of the project structure.

Tests: `make check`.

QA: use quickstart as usual.

https://code.launchpad.net/~frankban/juju-quickstart/code-reorg/+merge/241416

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/169380043/

Affected files (+372, -222 lines):
   M HACKING.rst
   A [revision details]
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/models/envs.py
   A quickstart/models/jenv.py
   M quickstart/serializers.py
   M quickstart/tests/helpers.py
   M quickstart/tests/models/test_envs.py
   A quickstart/tests/models/test_jenv.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py
   M quickstart/tests/test_serializers.py

« Back to merge proposal