Code review comment for lp:~frankban/juju-quickstart/bundle-urls

Revision history for this message
Brad Crittenden (bac) wrote :

Code LGTM

https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py
File quickstart/__init__.py (right):

https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py#newcode33
quickstart/__init__.py:33: (installing on an existing state server when
possible).
When not possible isn't there an additional machine?

https://codereview.appspot.com/75830045/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/75830045/diff/1/quickstart/manage.py#newcode72
quickstart/manage.py:72: # remote location.
I'd move this second comment to the actual location it happens.

https://codereview.appspot.com/75830045/diff/1/quickstart/tests/test_manage.py
File quickstart/tests/test_manage.py (right):

https://codereview.appspot.com/75830045/diff/1/quickstart/tests/test_manage.py#newcode112
quickstart/tests/test_manage.py:112: # The options object is correctly
set up when a jujucharms bumdle URL
typo: bundle

https://codereview.appspot.com/75830045/

« Back to merge proposal