lp:~frankban/juju-quickstart/bundle-urls

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 59

Juju GUI Hackers: Pending requested 2014-03-14

Diff: 440 lines (+226/-47)

7 files modified

README.rst (+2/-2)
quickstart/__init__.py (+24/-1)
quickstart/manage.py (+51/-25)
quickstart/settings.py (+4/-1)
quickstart/tests/test_manage.py (+23/-0)
quickstart/tests/test_utils.py (+103/-16)
quickstart/utils.py (+19/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1290569: Bundle URLs are confusing	High	Fix Released
Bug #1291588: quickstart doesn't allow for leaving off ~charmers for promulgated bundles.	High	Fix Released

Link a bug report

Related blueprints

64. By Francesco Banconi on 2014-03-14

Changes as per review.

63. By Francesco Banconi on 2014-03-14

Checkpoint.

62. By Francesco Banconi on 2014-03-14

Fix typos.

61. By Francesco Banconi on 2014-03-14

Fix docs and add epilog.

60. By Francesco Banconi on 2014-03-14

Support jujucharms URLs.

59. By Francesco Banconi on 2014-03-13

Make bundle user and revision optional.

58. By Francesco Banconi on 2014-03-13

Add missing files to manifest.

R=
CC=
https://codereview.appspot.com/75380044

57. By Francesco Banconi on 2014-03-12

Update requirements.

Make quickstart use the newer python-jujuclient
included in trusty.

R=rharding
CC=
https://codereview.appspot.com/74610043

56. By Francesco Banconi on 2014-03-11

Improve version handling.

Modify the app.ensure_dependencies function
so that it returns the Juju version tuple.
This way we allow for reusing the version
through the app and we can avoid calling
"juju version" multiple times.

Support local environments by installing
the juju-local meta-package in place of
specific packages (e.g. lxc, mongo).
This way we don't have to update quickstart
if core devs introduce new local env
dependencies.

Fix the destroy-environment message displayed
at the end of the process. The -e flag is
included when an old Juju is used.

Tests: `make check`.

QA: no strictly required.
Use .venv/bin/python juju-quickstart, check everything
works well, check the destroy-environment message
at the end of the process.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/74010044

55. By Francesco Banconi on 2014-03-10

SSH code reorganization.

This branch introduces a new ssh module
containing SSH handling related code.

The SSH functions previously in app are now
library functions in the ssh module.

ensure_ssh_keys is now the only app entry point
for the whole SSH keys management logic.

For the reasons above this branch mostly includes
code movements + some docstring/comments changes +
some exception handling changes.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/72520044