Code review comment for lp:~frankban/juju-quickstart/bundle-urls

Revision history for this message
Richard Harding (rharding) wrote :

Thanks for this, mainly reviewed the docs. A couple of suggestions. Let
me know if any of the comments are unclear.

https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py
File quickstart/__init__.py (right):

https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py#newcode34
quickstart/__init__.py:34: * Bundles can be deployed, from local files,
HTTP(S) URLs or the charm store,
URLs <comma>

https://codereview.appspot.com/75830045/diff/1/quickstart/__init__.py#newcode37
quickstart/__init__.py:37: into the GUI, to observe and manage the
environment visually.
into the Juju GUI. (I'd drop the rest)

https://codereview.appspot.com/75830045/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/75830045/diff/1/quickstart/manage.py#newcode332
quickstart/manage.py:332: '1) a fully qualified bundle URL, starting
with "bundle:"\n'
Can we word this to start with the easy example that's recommended by
moving the promulgated bundle up here.

Then word it more that "You can also specify a user bundle, and a
specific revision...

This way we push the promoted and simple case and fall back to any
person's work.

https://codereview.appspot.com/75830045/

« Back to merge proposal