Code review comment for lp:~frankban/juju-quickstart/bundle-urls

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+211057_code.launchpad.net,

Message:
Please take a look.

Description:
Improve bundle URLs support.

Add support for promulgated bundle short names.
Add support for jujucharms bundle URLs.
Improve help messages.

Tests: `make check`.

QA:

Run `.venv/bin/python juju-quickstart -h`
and please check the spelling of the whole
help message. Also ensure it is nicely
printed on a small terminal (e.g. 80x24).

Now let's check bundle errors: all the commands
below should return a pertinent error message:

.venv/bin/python juju-quickstart bundle:
.venv/bin/python juju-quickstart
https://jujucharms.com/bundle/mediawiki/single/wtf
.venv/bin/python juju-quickstart
https://jujucharms.com/bundle/mediawiki/double
.venv/bin/python juju-quickstart
https://jujucharms.com/charms/mediawiki/single
.venv/bin/python juju-quickstart bundle:mediawiki/42/single
.venv/bin/python juju-quickstart bundle:~frankban/mediawiki/single

Deploy bundles, destroy the environment after each command.

Deploy the promulgated mediawiki single bundle:
.venv/bin/python juju-quickstart bundle:~charmers/mediawiki/6/single

Deploy the mediawiki scalable bundle:
.venv/bin/python juju-quickstart bundle:mediawiki/scalable

Deploy a bundle using its jujucharms URLs:
.venv/bin/python juju-quickstart
https://jujucharms.com/bundle/~bac/charmworld-demo/charmworld-minimal/

Deploy a bundle using direct HTTPS:
.venv/bin/python juju-quickstart
https://raw.github.com/castrojo/mongodb-bundle/master/bundles.yaml

https://code.launchpad.net/~frankban/juju-quickstart/bundle-urls/+merge/211057

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/75830045/

Affected files (+229, -46 lines):
   M README.rst
   A [revision details]
   M quickstart/__init__.py
   M quickstart/manage.py
   M quickstart/settings.py
   M quickstart/tests/test_manage.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

« Back to merge proposal