Code review comment for lp:~frankban/juju-gui/inspector-who

Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+190379_code.launchpad.net,

Message:
Please take a look.

Description:
Fix links in the unit details view.

Handle the juju-core "port/protocol" ports.
Privilege the HTTPS port if applicable.

Also fixed the z-index of the charm browser tab,
so that when the sidebar and the unit details view
appear together in a narrow browser it is still
possible to close the sidebar.

QA:
- deploy the GUI with this branch in a juju-core env:
   juju bootstrap --debug
   juju deploy juju-gui
   juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/inspector-who
- wait for the unit to be ready;
- visit the juju-gui unit detail view;

You should be able to close the sidebar view.
The GUI address links to the right URL (https://).
The ports link to the right URLs without the trailing "/tcp".

https://code.launchpad.net/~frankban/juju-gui/inspector-who/+merge/190379

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14439054/

Affected files (+249, -41 lines):
   A [revision details]
   M app/views/utils.js
   M app/views/viewlets/unit-details.js
   M lib/views/browser/browser-icon.less
   M test/test_unit_detail_viewlet.js
   M test/test_utils.js

« Back to merge proposal