lp:~frankban/juju-gui/inspector-who

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 1125

Juju GUI Hackers: Pending requested 2013-10-10

Diff: 380 lines (+247/-41)

5 files modified

app/views/utils.js (+59/-0)
app/views/viewlets/unit-details.js (+32/-32)
lib/views/browser/browser-icon.less (+1/-1)
test/test_unit_detail_viewlet.js (+40/-8)
test/test_utils.js (+115/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1233811: Unit details view has links to "80/tcp", not port 80	High	Fix Released
Bug #1234321: the minimize tab should have a higher z-index than the inspector charm details	High	Fix Released

Link a bug report

Related blueprints

1127. By Francesco Banconi on 2013-10-10

Increased the bws icon z-index.

1126. By Francesco Banconi on 2013-10-10

Lint.

1125. By Francesco Banconi on 2013-10-10

Merged trunk.

1124. By Francesco Banconi on 2013-10-10

Checkpoint.

1123. By Jeff Pihach on 2013-10-10

Added the source code tab to bundle details view

R=gary.poster
CC=
https://codereview.appspot.com/14595045

1122. By Jeff Pihach on 2013-10-10

Adds charm icons to bundle token and detail view

R=gary.poster
CC=
https://codereview.appspot.com/14591044

1121. By Madison Scott-Clary on 2013-10-09

Fix upgrade text, remove feature flag

Upgrade service notification matches designs, feature flag for upgrade charm removed.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/14438061

1120. By Richard Harding on 2013-10-09

Prevent direct charm id routes mis-firing.

The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').

A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this

- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"

--Enter double dispatch

- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."

What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.

QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.

R=matthew.scott
CC=
https://codereview.appspot.com/14441054

1119. By Huw Wilkins on 2013-10-09

Styling for bundle details charm info

This branch styles the charm details panel that appears on the bundle details tab.

To test browse to http://localhost:8888/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=wiki and click the visible charm icon.

The panel shows a square before the icon has been clicked. This is because the panel showing/hiding has not been implemented yet. This is also why the close icon currently does nothing.

R=gary.poster
CC=
https://codereview.appspot.com/14483046

1118. By Huw Wilkins on 2013-10-09

Changed recommended charm indicator

Added the new recommended charm indicator to the charm token and charm/bundle details.

Moved the selected token line to the left as per new mockups.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/14526043