Code review comment for lp:~frankban/juju-gui/bug-1081803-tests-mutate-url

Revision history for this message
Gary Poster (gary) wrote :

Really nice cleanups, Francesco. Thank you. Please land it!

Gary

https://codereview.appspot.com/6856075/diff/5001/test/test_app.js
File test/test_app.js (left):

https://codereview.appspot.com/6856075/diff/5001/test/test_app.js#oldcode44
test/test_app.js:44: // XXX Apparently removing a DOM node is
asynchronous (on Chrome at least)
Weird that this comment is not in trunk. Not worrying about it.

I agree that the tests seem reliable on Chrome without this code, so
ripping it out seems fine.

https://codereview.appspot.com/6856075/

« Back to merge proposal