lp:~frankban/juju-gui/bug-1081803-tests-mutate-url
- Get this branch:
- bzr branch lp:~frankban/juju-gui/bug-1081803-tests-mutate-url
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 143 lines (+35/-34)2 files modifiedtest/test_app.js (+10/-9)
test/test_app_hotkeys.js (+25/-25)
Branch information
Recent revisions
- 255. By Madison Scott-Clary
-
Fix initial creation of subordinates.
When creating a subordinate service initially, it was not being laid out properly by the pack layout, nor was it seeming to have drag events attached. Pack layout was expecting a value accessor function to return some number greater than zero when constructing its radius, which informs the x/y coordinates. Returning zero results in NaN for all three values, thus positioning the service at (0,0) and causing drag events to fail when updating the service's coordinates with dx/dy + NaN. This branch fixes this by ensuring that zero is never returned as the node's value. This fix is quick and intended to make the UI function with the current layout algorithm. Future layout algorithms, if they're designed by hand, will need to keep this in mind as well.
R=benjamin.saller, bac
CC=
https://codereview. appspot. com/6856067 - 254. By Thiago Veronezi
-
application hotkeys
The user can hit alt+e to open the environment view and alt+s to focus the
charm search field.R=matthew.scott, benjamin.saller
CC=
https://codereview. appspot. com/6849078 - 253. By Gary Poster
-
Add favicon, tweak Makefile
Added the juju icon as a favicon, and then got lost in Makefile tweaks. Makefile now does not do unnecessary work, and no longer hides commands with @ so that we can see when we reintroduce unnecessary work. Also switch from a Makefile comment about the node_modules to a message generated by the Makefile.
R=thiago
CC=
https://codereview. appspot. com/6842072 - 252. By Brad Crittenden
-
Fix overflow on charm name.
The sections in the charm search results pane are fixed at 70px high.
Due to the way we construct the name, and the fact the charm authors
can set the name to be anything they want, some names exceed the
allotted one-line and wreak havoc on the layout.Obvious lesson learned: any element with a fixed height and
user-supplied data must account for overflow.The deploy button placement was also fixed.
Matt C. has seen screenshots of the truncation and offered tweaks on
the vertical spacing which are incorporated here.R=matthew.scott, thiago
CC=
https://codereview. appspot. com/6843082 - 251. By Thiago Veronezi
-
Makefile does not support static file deployment
Full description here: https:/
/bugs.launchpad .net/juju- gui/+bug/ 1078898 This branch does not support CSS minification. It only combines the third-party css files. The minification of the YUI and our custom CSS files is covered by another branch;
The "make debug" command starts the node.js server with the debug version of our application;
The "make server" command starts a python SimpleHTTPServer service with the production version of our application. Note that it is not possible to use REST with this version. It will be covered by another card;
R=bac, gary.poster
CC=
https://codereview. appspot. com/6844061
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental