On 2012/11/12 18:28:34, bac wrote:
> Thanks Francesco. I'm concerned about being able to repeatedly open
and close
> the Charms panel using the top-level twisty.
> Also I note with your branch that after loading I can click on the
Charms icon
> at the top and have it work exactly once. If I close it I cannot
reopen.
> Please check that behavior in your branch before submitting.
Works for me locally, after cleaning the browser cache.
> Additionally it doesn't look like the chevron twists for the top
Charms label.
They are correctly replaced here. :-/ I think some kind of cache is
hitting us.
On 2012/11/12 18:28:34, bac wrote:
> Thanks Francesco. I'm concerned about being able to repeatedly open
and close
> the Charms panel using the top-level twisty.
> Otherwise, looks good.
Thanks for the review Brad.
https:/ /codereview. appspot. com/6819131/ diff/1/ app/templates/ charm-descripti on.handlebars charm-descripti on.handlebars (right):
> File app/templates/
https:/ /codereview. appspot. com/6819131/ diff/1/ app/templates/ charm-descripti on.handlebars# newcode15 charm-descripti on.handlebars: 15: <h4 class="first"><i
> app/templates/
> class="sprite chevron_up"></i> Description</h4>
> I find chevron-up vs -down counter intuitive but it matches the visual
design.
Agreed.
> Also I note with your branch that after loading I can click on the
Charms icon
> at the top and have it work exactly once. If I close it I cannot
reopen.
> Please check that behavior in your branch before submitting.
Works for me locally, after cleaning the browser cache.
> Additionally it doesn't look like the chevron twists for the top
Charms label.
They are correctly replaced here. :-/ I think some kind of cache is
hitting us.
https:/ /codereview. appspot. com/6819131/