lp:~frankban/juju-gui/bug-1075672-icons

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 237

Juju GUI Hackers: Pending requested 2012-11-12

Diff: 225 lines (+41/-21)

7 files modified

app/index.html (+1/-1)
app/templates/charm-description.handlebars (+5/-5)
app/templates/charm-pre-configuration.handlebars (+1/-1)
app/views/charm-panel.js (+29/-7)
lib/views/stylesheet.less (+2/-1)
test/test_charm_panel.js (+3/-3)
undocumented (+0/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1075672: Charm panel icons are not per visual spec

High

Fix Released

Link a bug report

Related blueprints

240. By Francesco Banconi on 2012-11-12

Added docstrings.

239. By Francesco Banconi on 2012-11-12

Lint.

238. By Francesco Banconi on 2012-11-12

Fixed tests.

237. By Francesco Banconi on 2012-11-12

Updated icons.

236. By Madison Scott-Clary on 2012-11-09

Lightweight assets/improve FF performance

Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.setAttribute() and <node>.getClientRects()). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6826057

235. By Thiago Veronezi on 2012-11-09

Resource minification/aggregation js

* We should aggregate and minimize the js sources in order to improve the load speed of the application;
* We dont want to use the yui combo loader feature;
* The final product will provide three js files: one for the YUI dependencies, one for our custom js code and one for third part js like d3.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6821090

234. By Francesco Banconi on 2012-11-09

Charm config panel visual design fixes.

The charm configuration panel now should match UX wireframe.
This branch also contains fixes to the configuration
section hiding when a config file is uploaded.
Also introduced LESS mixins for border radii and box shadows.
Added "docstrings" to relevant charm panel methods.

R=bac, gary.poster
CC=
https://codereview.appspot.com/6827066

233. By Benji York on 2012-11-08

improve draglines

R=
CC=
https://codereview.appspot.com/6818107

232. By Thiago Veronezi on 2012-11-08

Generic show view event

Instead of wrapping the 'navigate' method call with multiple 'show' events, we want call the 'navigate' method from a single event.

So, instead of...

this.on('*:showService', this.navigate_to_service);
this.on('*:showUnit', this.navigate_to_unit);
this.on('*:showCharm', this.navigate_to_charm);
this.on('*:showEnvironment', this.navigate_to_environment);

... we will have...

this.on('*:navigateTo', function(e) {
 console.log('navigateTo', e);
 this.navigate(e.url);
}, this);

R=benji, bac
CC=
https://codereview.appspot.com/6819104

231. By Brad Crittenden on 2012-11-08

Style charm results panel.

Does not include filter dropdown as that design is not finalized.

Added further styling as specified by Matt.

R=
CC=
https://codereview.appspot.com/6817101