Code review comment for lp:~frankban/juju-gui/bug-1075672-icons

Revision history for this message
Brad Crittenden (bac) wrote :

Thanks Francesco. I'm concerned about being able to repeatedly open and
close the Charms panel using the top-level twisty.

Otherwise, looks good.

https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description.handlebars
File app/templates/charm-description.handlebars (right):

https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description.handlebars#newcode15
app/templates/charm-description.handlebars:15: <h4 class="first"><i
class="sprite chevron_up"></i> Description</h4>
I find chevron-up vs -down counter intuitive but it matches the visual
design.

Also I note with your branch that after loading I can click on the
Charms icon at the top and have it work exactly once. If I close it I
cannot reopen. Please check that behavior in your branch before
submitting.

Additionally it doesn't look like the chevron twists for the top Charms
label.

https://codereview.appspot.com/6819131/

« Back to merge proposal