Merge lp:~frankban/charms/precise/juju-gui/deployer-031 into lp:~juju-gui/charms/precise/juju-gui/trunk

[Francesco Banconi]

Update deployer to 0.3.1

Update the juju-deployer package to the newer version.
As a consequence, improve the bundle deployment feedback.

Tests: `make unittest`.

QA:
1) deploy the charm by bootstrapping juju and
then running `make deploy`.

2) wait for the service to be ready/started.

3) Open the GUI.

4) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844154/

5) You should see an error in the GUI:
The deployment errored: Invalid config charm
cs:~openstack-ubuntu-testing/precise/mysql-4
no-such-option=42

6) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844187/

7) You should see an error in the GUI:
The deployment errored: Invalid relation in config,
service no-such not found,
rel mediawiki:db <-> no-such:db

Done, thank you!

https://codereview.appspot.com/55230044/

[Francesco Banconi (frankban)]

Reviewers: mp+203999_code.launchpad.net,

Message:
Please take a look.

Description:
Update deployer to 0.3.1

Update the juju-deployer package to the newer version.
As a consequence, improve the bundle deployment feedback.

Tests: `make unittest`.

QA:
1) deploy the charm by bootstrapping juju and
then running `make deploy`.

2) wait for the service to be ready/started.

3) Open the GUI.

4) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844154/

5) You should see an error in the GUI:
The deployment errored: Invalid config charm
cs:~openstack-ubuntu-testing/precise/mysql-4
no-such-option=42

6) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844187/

7) You should see an error in the GUI:
The deployment errored: Invalid relation in config,
service no-such not found,
rel mediawiki:db <-> no-such:db

Done, thank you!

https://code.launchpad.net/~frankban/charms/precise/juju-gui/deployer-031/+merge/203999

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/55230044/

Affected files (+1, -1 lines):
   A [revision details]
   D deps/juju-deployer-0.3.1-prerelease.tar.gz
   A deps/juju-deployer-0.3.1.tar.gz
   M server-requirements.pip

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision:
<email address hidden>

Index: server-requirements.pip
=== modified file 'server-requirements.pip'
--- server-requirements.pip 2014-01-28 11:01:55 +0000
+++ server-requirements.pip 2014-01-30 14:48:55 +0000
@@ -27,6 +27,4 @@
  tornado==3.1.1
  websocket-client==0.12.0
  jujuclient==0.15
-# Pre-release version of juju-deployer built from:
-# lp:~bac/juju-deployer/0.3.1-prerelease
-juju-deployer==0.3.1-prerelease
+juju-deployer==0.3.1

Index: deps/juju-deployer-0.3.1-prerelease.tar.gz
=== removed file 'deps/juju-deployer-0.3.1-prerelease.tar.gz'
Binary files deps/juju-deployer-0.3.1-prerelease.tar.gz 2014-01-22 15:24:00
+0000 and deps/juju-deployer-0.3.1-prerelease.tar.gz 1970-01-01 00:00:00
+0000 differ

Index: deps/juju-deployer-0.3.1.tar.gz
=== added file 'deps/juju-deployer-0.3.1.tar.gz'
Binary files deps/juju-deployer-0.3.1.tar.gz 1970-01-01 00:00:00 +0000 and
deps/juju-deployer-0.3.1.tar.gz 2014-01-30 14:48:55 +0000 differ

[Gary Poster (gary)]

LGTM

https://codereview.appspot.com/55230044/

[Jeff Pihach (hatch)]

LGTM QA OK (from Makyo)

https://codereview.appspot.com/55230044/

[Francesco Banconi (frankban)]

*** Submitted:

Update deployer to 0.3.1

Update the juju-deployer package to the newer version.
As a consequence, improve the bundle deployment feedback.

Tests: `make unittest`.

QA:
1) deploy the charm by bootstrapping juju and
then running `make deploy`.

2) wait for the service to be ready/started.

3) Open the GUI.

4) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844154/

5) You should see an error in the GUI:
The deployment errored: Invalid config charm
cs:~openstack-ubuntu-testing/precise/mysql-4
no-such-option=42

6) Try to deploy this bundle file:
http://pastebin.ubuntu.com/6844187/

7) You should see an error in the GUI:
The deployment errored: Invalid relation in config,
service no-such not found,
rel mediawiki:db <-> no-such:db

Done, thank you!

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/55230044

https://codereview.appspot.com/55230044/

[Francesco Banconi (frankban)]

Thank you!

https://codereview.appspot.com/55230044/

=== removed file 'deps/juju-deployer-0.3.1-prerelease.tar.gz'
Binary files deps/juju-deployer-0.3.1-prerelease.tar.gz	2014-01-22 15:24:00 +0000 and deps/juju-deployer-0.3.1-prerelease.tar.gz	1970-01-01 00:00:00 +0000 differ
=== added file 'deps/juju-deployer-0.3.1.tar.gz'
Binary files deps/juju-deployer-0.3.1.tar.gz	1970-01-01 00:00:00 +0000 and deps/juju-deployer-0.3.1.tar.gz	2014-01-30 15:25:57 +0000 differ
=== modified file 'server-requirements.pip'
--- server-requirements.pip	2014-01-28 11:01:55 +0000
+++ server-requirements.pip	2014-01-30 15:25:57 +0000
@@ -27,6 +27,4 @@
 tornado==3.1.1
 websocket-client==0.12.0
 jujuclient==0.15
-# Pre-release version of juju-deployer built from:
-# lp:~bac/juju-deployer/0.3.1-prerelease
-juju-deployer==0.3.1-prerelease
+juju-deployer==0.3.1