Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

Proposed by Shih-Yuan Lee
Status: Merged
Merged at revision: 3964ee14468eb6d60e0ac73e50fb3737d6831e60
Proposed branch: ~fourdollars/pc-enablement/+git/oem-scripts:master
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master
Diff against target: 22 lines (+4/-0)
1 file modified
mir-bug (+4/-0)
Reviewer Review Type Date Requested Status
Yao Wei Approve
Review via email: mp+426529@code.launchpad.net
To post a comment you must log in.
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.43-e2f51dd-in-linux-container-jammy

Revision history for this message
Yao Wei (medicalwei) :
review: Needs Information
Revision history for this message
Yao Wei (medicalwei) wrote :

Thanks for clarifications. The purpose of the commit is to let Cert team know all units that need to be certified in this MIR bug.

Discussions: https://chat.canonical.com/canonical/pl/s489bxogu78t3kyi1i7nxb7eqy

review: Approve
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
bootstrap-meta FAIL non-zero exit status 1
mir-bug PASS
oem-meta-packages SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.43-f0a5783-in-linux-container-jammy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/mir-bug b/mir-bug
index 4f0c65d..ebdd832 100755
--- a/mir-bug
+++ b/mir-bug
@@ -27,6 +27,7 @@ import lazr
27import oem_scripts27import oem_scripts
28import os28import os
29import re29import re
30import requests
30import shutil31import shutil
31import sys32import sys
3233
@@ -497,6 +498,9 @@ def check_bug_description(bug, certified_hardwares: list) -> (str, str):
497 desc += "\n"498 desc += "\n"
498499
499 for hardware in certified_hardwares:500 for hardware in certified_hardwares:
501 response = requests.get(f"https://ubuntu.com/certified/{hardware}")
502 if response.status_code != 200:
503 continue
500 desc += f"\nhttps://ubuntu.com/certified/{hardware}"504 desc += f"\nhttps://ubuntu.com/certified/{hardware}"
501505
502 if bug.description != desc:506 if bug.description != desc:

Subscribers

People subscribed via source and target branches