Merge ~fourdollars/pc-enablement/+git/oem-scripts:master into ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master

Proposed by Shih-Yuan Lee
Status: Merged
Approved by: Shih-Yuan Lee
Approved revision: 7af06c39412d7fb0d8032baa16c7fcdabdf95c33
Merged at revision: da18a458e876e2b4963a699e4546523a13b42cac
Proposed branch: ~fourdollars/pc-enablement/+git/oem-scripts:master
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-scripts:master
Diff against target: 35 lines (+13/-1)
2 files modified
debian/tests/setup-apt-dir (+2/-0)
setup-apt-dir.sh (+11/-1)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Approve
Review via email: mp+417007@code.launchpad.net
To post a comment you must log in.
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bootstrap-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir FAIL non-zero exit status 1
mir-bug SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.29-fc9d3fa-in-linux-container-focal

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM

review: Approve
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
autopkgtest-collect-credentials PASS
autopkgtest-oem-scripts-auto PASS
pkg-somerville-meta PASS
pkg-stella-meta PASS
pkg-sutton-meta PASS
bootstrap-meta PASS
bug-bind PASS
get-private-ppa PASS
jq-lp PASS
launchpad-api PASS
lp-bug PASS
oem-meta-packages PASS
pkg-list PASS
review-merge-proposal PASS
run-autopkgtest PASS
setup-apt-dir PASS
mir-bug SKIP exit status 77 and marked as skippable
git-url-insteadof-setting PASS
lp-dl-attm PASS
recovery-from-iso.sh PASS

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/oem-scripts/oem-scripts-1.29-7af06c3-in-linux-container-focal

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/tests/setup-apt-dir b/debian/tests/setup-apt-dir
index f2fa1b5..b46d790 100644
--- a/debian/tests/setup-apt-dir
+++ b/debian/tests/setup-apt-dir
@@ -2,6 +2,8 @@
22
3export LAUNCHPAD_TOKEN="::"3export LAUNCHPAD_TOKEN="::"
44
5setup-apt-dir.sh -c jammy -m http://archive.ubuntu.com/ubuntu --disable-updates --disable-backports -o aptdir.log
6rm -f aptdir.log
5setup-apt-dir.sh -c focal -m http://archive.ubuntu.com/ubuntu --disable-updates --disable-backports -o aptdir.log7setup-apt-dir.sh -c focal -m http://archive.ubuntu.com/ubuntu --disable-updates --disable-backports -o aptdir.log
6if [ ! -e aptdir.log ]; then8if [ ! -e aptdir.log ]; then
7 echo "aptdir.log doesn't exist."9 echo "aptdir.log doesn't exist."
diff --git a/setup-apt-dir.sh b/setup-apt-dir.sh
index 2c999e3..67adf99 100755
--- a/setup-apt-dir.sh
+++ b/setup-apt-dir.sh
@@ -175,7 +175,17 @@ if [ "${#PPA[@]}" != "0" ]; then
175 done< <(get-private-ppa "${PPA[@]}")175 done< <(get-private-ppa "${PPA[@]}")
176fi176fi
177177
178PUBKEY="790BC7277767219C42C86F933B4FE6ACC0B21F32"178case "${CODENAME}" in
179 (bionic|focal)
180 PUBKEY="790BC7277767219C42C86F933B4FE6ACC0B21F32"
181 ;;
182 (hirsute|impish|jammy)
183 PUBKEY="F6ECB3762474EDA9D21B7022871920D1991BC93C"
184 ;;
185 (*)
186 echo "${CODENAME} is not supported by setup-apt-dir.sh yet."
187 ;;
188esac
179189
180: > "$APTDIR/etc/apt/sources.list"190: > "$APTDIR/etc/apt/sources.list"
181191

Subscribers

People subscribed via source and target branches