Merge lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support into lp:ubiquity

Proposed by fossfreedom
Status: Merged
Merged at revision: 6502
Proposed branch: lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support
Merge into: lp:ubiquity
Diff against target: 58 lines (+15/-4)
2 files modified
bin/ubiquity-dm (+9/-4)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~fossfreedom/ubiquity/fix_add_ubuntu_budgie_support
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+314267@code.launchpad.net

Description of the change

This adds support for Ubuntu Budgie (LP: #1654368)

To post a comment you must log in.
6503. By fossfreedom

corrected bug report - 1654368

Revision history for this message
Colin Watson (cjwatson) :
review: Approve
6504. By fossfreedom

slightly restructure to reduce code duplication

Revision history for this message
fossfreedom (fossfreedom) wrote :

Many thanks Colin,

  have made those changes requested. Have done a debuild, as well as tested the resulting .debs in a live-session.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/ubiquity-dm'
--- bin/ubiquity-dm 2016-12-02 14:58:25 +0000
+++ bin/ubiquity-dm 2017-01-07 10:10:26 +0000
@@ -492,7 +492,8 @@
492 ('org.mate.background', 'picture-filename',492 ('org.mate.background', 'picture-filename',
493 "''"))493 "''"))
494494
495 if osextras.find_on_path('gnome-shell'):495 if (osextras.find_on_path('gnome-shell') or
496 osextras.find_on_path('budgie-wm')):
496 gsettings_keys.append(497 gsettings_keys.append(
497 ('org.gnome.settings-daemon.plugins.background',498 ('org.gnome.settings-daemon.plugins.background',
498 'active', 'false'))499 'active', 'false'))
@@ -551,6 +552,8 @@
551552
552 if osextras.find_on_path('gnome-shell'):553 if osextras.find_on_path('gnome-shell'):
553 wm_cmd = ['gnome-shell', '--sm-disable', '--mode=ubiquity']554 wm_cmd = ['gnome-shell', '--sm-disable', '--mode=ubiquity']
555 elif osextras.find_on_path('budgie-wm'):
556 wm_cmd = ['budgie-wm', '--sm-disable']
554 elif osextras.find_on_path('marco'):557 elif osextras.find_on_path('marco'):
555 wm_cmd = ['marco', '--sm-disable']558 wm_cmd = ['marco', '--sm-disable']
556 elif osextras.find_on_path('metacity'):559 elif osextras.find_on_path('metacity'):
@@ -569,8 +572,9 @@
569 else:572 else:
570 raise MissingProgramError(573 raise MissingProgramError(
571 'No window manager found (tried '574 'No window manager found (tried '
572 'marco, metacity, xfwm4, matchbox-window-manager, '575 'gnome-shell, budgie-wm, marco, metacity, xfwm4, '
573 'openbox-lubuntu, openbox, compiz)')576 'matchbox-window-manager, openbox-lubuntu, '
577 'openbox, compiz)')
574578
575 wm = subprocess.Popen(579 wm = subprocess.Popen(
576 wm_cmd, stdin=null, stdout=logfile, stderr=logfile,580 wm_cmd, stdin=null, stdout=logfile, stderr=logfile,
@@ -596,7 +600,8 @@
596 if os.path.exists('/usr/lib/ubiquity/panel'):600 if os.path.exists('/usr/lib/ubiquity/panel'):
597 if ("openbox-lubuntu" not in wm_cmd and601 if ("openbox-lubuntu" not in wm_cmd and
598 "openbox" not in wm_cmd and602 "openbox" not in wm_cmd and
599 "gnome-shell" not in wm_cmd):603 "gnome-shell" not in wm_cmd and
604 "budgie-wm" not in wm_cmd):
600 multiarchdir = os.path.split(605 multiarchdir = os.path.split(
601 sysconfig.get_config_var('multiarchsubdir'))[-1]606 sysconfig.get_config_var('multiarchsubdir'))[-1]
602 indicators = list(filter(os.path.isfile, [607 indicators = list(filter(os.path.isfile, [
603608
=== modified file 'debian/changelog'
--- debian/changelog 2016-12-05 12:39:44 +0000
+++ debian/changelog 2017-01-07 10:10:26 +0000
@@ -1,3 +1,9 @@
1ubiquity (17.04.2) zesty; urgency=medium
2
3 * Update ubiquity-dm to support Ubuntu Budgie (LP: #1654368)
4
5 -- David Mohammed <fossfreedom@ubuntu.com> Fri, 06 Jan 2017 23:23:30 +0000
6
1ubiquity (17.04.1) zesty; urgency=medium7ubiquity (17.04.1) zesty; urgency=medium
28
3 * Update sources to zesty.9 * Update sources to zesty.

Subscribers

People subscribed via source and target branches

to status/vote changes: