Code review comment for lp:~fgimenez/snappy/activate-test

Revision history for this message
Leo Arias (elopio) wrote :

cool. Just please rename it to basic-binaries so I can add my failed bin.
Also take a look from my branch of the constants I moved to the data.go. If you like it you can do that here, or I'll update your const on my branch once yours lands.

Here's an idea: Lets make a snaps cache, so we have to build them only once. I'll make a card.

About:

+func (s *activateSuite) TestSnapIsInstalled(c *check.C) {

I'm not sure. Do we need it? common.InstallSnap(c, s.snapPath) would fail if something is wrong, and we already have a test to check that list shows the installed snaps.

review: Needs Fixing

« Back to merge proposal